mirrors/LegacyUpdate
1
0
Fork 0
mirror of https://github.com/LegacyUpdate/LegacyUpdate.git synced 2025-01-22 14:12:07 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fix GetOwnVersion() freeing filename too soon

Browse source
This commit is contained in:
Adam Demasi 2024-09-30 03:05:40 +09:30
parent c99bd36cd1
commit 0848263d4f
No known key found for this signature in database
GPG key ID: 5D3B26B3D58C7D91
1 changed files with 5 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
shared/VersionInfo.c
View file

@ -6,6 +6,8 @@ static LPWSTR _version;
HRESULT GetOwnVersion(LPWSTR *version) {
if (!_loadedOwnVersion) {
_loadedOwnVersion = TRUE;
LPWSTR filename;
GetOwnFileName(&filename);
@ -16,14 +18,15 @@ HRESULT GetOwnVersion(LPWSTR *version) {
return HRESULT_FROM_WIN32(GetLastError());
}
LocalFree(filename);
LPVOID verInfo = LocalAlloc(LPTR, verInfoSize);
if (!GetFileVersionInfo(filename, verHandle, verInfoSize, verInfo)) {
LocalFree(filename);
LocalFree(verInfo);
return HRESULT_FROM_WIN32(GetLastError());
}
LocalFree(filename);
UINT size;
if (!VerQueryValue(verInfo, L"\\StringFileInfo\\040904B0\\ProductVersion", (LPVOID *)&_version, &size)) {
LocalFree(verInfo);