mirrors/OpenRCT2
1
0
Fork 0
mirror of https://github.com/OpenRCT2/OpenRCT2.git synced 2025-01-22 10:21:57 -05:00
Code Issues Projects Releases Packages Wiki Activity

Replace call by address with function name

Browse source 
Call news_item_get_subject_location by name rather than its address.
Also add short description of function
This commit is contained in:
Peter Hill 2014-04-27 20:27:12 +02:00
parent 781d0fdf26
commit 746000f0cd
3 changed files with 16 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/news_item.c
View file

@ -165,7 +165,9 @@ static int news_item_get_new_history_slot()
}
/**
*
* Get the (x,y,z) coordinates of the subject of a news item.
* If the new item is no longer valid, return 0x8000 in the x-coordinate
*
* rct2: 0x0066BA74
*/
void news_item_get_subject_location(int type, int subject, int *x, int *y, int *z)

2
src/news_item.h
View file

@ -56,5 +56,5 @@ typedef struct {
void news_item_init_queue();
void news_item_update_current();
void news_item_close_current();
void news_item_get_subject_location(int type, int subject, int *x, int *y, int *z);
#endif

23
src/window_game_bottom_toolbar.c
View file

@ -179,15 +179,16 @@ static void window_game_bottom_toolbar_mouseup()
break;
{
uint32 eax, ebx, ecx, edx, esi, edi, ebp;
ecx = newsItem->assoc;
edx = newsItem->type;
RCT2_CALLFUNC_X(0x0066BA74, &eax, &ebx, &ecx, &edx, &esi, &edi, &ebp);
if ((eax & 0xFFFF) == 0x8000)
int x, y, z;
int subject = newsItem->assoc;
news_item_get_subject_location(newsItem->type, subject, &x, &y, &z);
if (x == 0x8000)
break;
if ((mainWindow = window_get_main()) != NULL)
window_scroll_to_location(mainWindow, eax & 0xFFFF, ecx & 0xFFFF, edx & 0xFFFF);
window_scroll_to_location(mainWindow, x, y, z);
}
break;
case WIDX_RIGHT_OUTSET:
@ -278,12 +279,12 @@ static void window_game_bottom_toolbar_invalidate()
w->disabled_widgets &= ~(1 << WIDX_NEWS_SUBJECT);
w->disabled_widgets &= ~(1 << WIDX_NEWS_LOCATE);
int eax, ebx, ecx, edx, esi, edi, ebp;
ecx = newsItem->assoc;
edx = newsItem->type;
RCT2_CALLFUNC_X(0x0066BA74, &eax, &ebx, &ecx, &edx, &esi, &edi, &ebp);
// Find out if the news item is no longer valid
int x, y, z;
int subject = newsItem->assoc;
news_item_get_subject_location(newsItem->type, subject, &x, &y, &z);
if ((eax & 0xFFFF) == 0x8000)
if (x == 0x8000)
w->disabled_widgets |= (1 << WIDX_NEWS_LOCATE);
if (!(((char*)0x0097BE7C)[newsItem->type] & 2)) {