mirrors/blender
1
0
Fork 0
mirror of https://projects.blender.org/blender/blender.git synced 2025-01-22 15:32:15 -05:00
Code Issues Projects Releases Packages Wiki Activity

Extensions: adjust the error about failure to sync when offline

Browse source 
- Suppress the warning entirely when the "first time" message
  requesting online access is shown as it adds unnecessary noise.

- Otherwise, when offline, show a message suggesting to allow online
  access or disable the repository.
This commit is contained in:
Campbell Barton 2024-06-24 12:15:46 +10:00
parent e48a9fc5ed
commit 2eaf70a4ed
1 changed files with 28 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

32
scripts/addons_core/bl_pkg/bl_extension_ui.py
View file

@ -942,11 +942,35 @@ def extensions_panel_draw_impl(
# NOTE: it would be nice to detect when the repository ran sync and it failed.
# This isn't such an important distinction though, the main thing users should be aware of
# is that a "sync" is required.
errors_on_draw.append(
"Repository: \"{:s}\" must sync with the remote repository.".format(
repos_all[repo_index].name,
if bpy.app.online_access:
errors_on_draw.append(
(
"Repository: \"{:s}\" remote data unavailable, "
"sync with the remote repository."
).format(
repos_all[repo_index].name,
)
)
elif prefs.extensions.use_online_access_handled is False:
# Hide this message when online access hasn't been handled
# as it's unnecessarily noisy to show both messages at once.
pass
else:
# This message could also be suppressed when offline after all it is not a surprise that
# the remote data is not available when offline. Don't do this for the following reasons.
#
# - Keeping a remote repository enable when offline, while supported is likely to cause
# errors/reports elsewhere and this is a hint that data which is expected to display is missing.
# - It's possible to use remote `file://` URL's when offline.
# Repositories which don't require online access shouldn't have their errors suppressed.
errors_on_draw.append(
(
"Repository: \"{:s}\" remote data unavailable, "
"either allow \"Online Access\" or disable the repository to suppress this message"
).format(
repos_all[repo_index].name,
)
)
)
continue
repo_module_prefix = pkg_repo_module_prefix(repos_all[repo_index])