mirrors/blender
1
0
Fork 0
mirror of https://projects.blender.org/blender/blender.git synced 2025-01-22 15:32:15 -05:00
Code Issues Projects Releases Packages Wiki Activity

Fix #132976: Crash animating along a 1-segment path

Browse source 
The binary lookup assumed there was at least two elements in the array.
This commit is contained in:
Campbell Barton 2025-01-13 16:23:19 +11:00
parent 9051c11b72
commit 5ceaff9aa6
1 changed files with 9 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
source/blender/blenkernel/intern/anim_path.cc
View file

@ -184,7 +184,16 @@ static bool binary_search_anim_path(const float *accum_len_arr,
int cur_idx = 0, cur_base = 0; int cur_idx = 0, cur_base = 0;
int cur_step = seg_size - 1; int cur_step = seg_size - 1;
/* Special case, for a single segment accessing the `right_len`
* would be an invalid index, see: #132976. */
if (UNLIKELY(seg_size == 1)) {
*r_idx = 0;
*r_frac = goal_len / accum_len_arr[0];
return true;
}
while (true) { while (true) {
BLI_assert(cur_idx + 1 < seg_size);
cur_idx = cur_base + cur_step / 2; cur_idx = cur_base + cur_step / 2;
left_len = accum_len_arr[cur_idx]; left_len = accum_len_arr[cur_idx];
right_len = accum_len_arr[cur_idx + 1]; right_len = accum_len_arr[cur_idx + 1];