mirrors/godot
1
0
Fork 0
mirror of https://github.com/godotengine/godot.git synced 2025-01-23 11:03:13 -05:00
Code Issues Projects Releases Packages Wiki Activity

Don't allow to use too big or too small shift operators

Browse source
This commit is contained in:
Rafał Mikrut 2019-12-12 20:00:26 +01:00
parent 8eb183aebb
commit 162a64efcd
1 changed files with 4 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
core/variant_op.cpp
View file

@ -1118,6 +1118,8 @@ void Variant::evaluate(const Operator &p_op, const Variant &p_a,
CASE_TYPE(math, OP_SHIFT_LEFT, INT) { CASE_TYPE(math, OP_SHIFT_LEFT, INT) {
if (p_b.type != INT) if (p_b.type != INT)
_RETURN_FAIL; _RETURN_FAIL;
if (p_b._data._int < 0 || p_b._data._int >= 64)
_RETURN_FAIL;
_RETURN(p_a._data._int << p_b._data._int); _RETURN(p_a._data._int << p_b._data._int);
} }
@ -1129,6 +1131,8 @@ void Variant::evaluate(const Operator &p_op, const Variant &p_a,
CASE_TYPE(math, OP_SHIFT_RIGHT, INT) { CASE_TYPE(math, OP_SHIFT_RIGHT, INT) {
if (p_b.type != INT) if (p_b.type != INT)
_RETURN_FAIL; _RETURN_FAIL;
if (p_b._data._int < 0 || p_b._data._int >= 64)
_RETURN_FAIL;
_RETURN(p_a._data._int >> p_b._data._int); _RETURN(p_a._data._int >> p_b._data._int);
} }