mirrors/godot
1
0
Fork 0
mirror of https://github.com/godotengine/godot.git synced 2025-01-23 11:03:13 -05:00
Code Issues Projects Releases Packages Wiki Activity

Don't recursively call _update_tree

Browse source 
When a node was previously selected and the test "selected == p_node"
was true the code would use set_selected() to change the selection to
nullptr. However, if the tree is dirty, which is always true in this
codepath, this would lead to a recursive call to _update_tree()
ultimately leading to a crash due to us running out of stack.

This fixes #100666
This commit is contained in:
HP van Braam 2024-12-20 23:01:44 +01:00
parent 89001f91d2
commit 62cff66383
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
editor/gui/scene_tree_editor.cpp
View file

@ -369,7 +369,7 @@ void SceneTreeEditor::_update_node_subtree(Node *p_node, TreeItem *p_parent, boo
item->set_selectable(0, false);
item->deselect(0);
if (selected == p_node) {
set_selected(nullptr, false);
selected = nullptr;
}
}
}