mirrors/godot
1
0
Fork 0
mirror of https://github.com/godotengine/godot.git synced 2025-01-23 19:12:24 -05:00
Code Issues Projects Releases Packages Wiki Activity

Merge pull request #72804 from vnen/gdscript-no-onready-without-node

Browse source 
GDScript: Fix inheritance check of @onready for inner classes
This commit is contained in:
Yuri Sizov 2023-02-06 23:03:44 +03:00 • committed by GitHub
commit 7b86a082be
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
5 changed files with 19 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
modules/gdscript/gdscript_parser.cpp
View file

@ -3619,7 +3619,7 @@ bool GDScriptParser::icon_annotation(const AnnotationNode *p_annotation, Node *p
bool GDScriptParser::onready_annotation(const AnnotationNode *p_annotation, Node *p_node) {
ERR_FAIL_COND_V_MSG(p_node->type != Node::VARIABLE, false, R"("@onready" annotation can only be applied to class variables.)");
if (head && !ClassDB::is_parent_class(head->get_datatype().native_type, SNAME("Node"))) {
if (current_class && !ClassDB::is_parent_class(current_class->get_datatype().native_type, SNAME("Node"))) {
push_error(R"("@onready" can only be used in classes that inherit "Node".)", p_annotation);
}

7
modules/gdscript/tests/scripts/analyzer/errors/onready_within_non_node_inner_class.gd Normal file
View file

@ -0,0 +1,7 @@
extends Node
class Inner extends RefCounted:
@onready var nope = 0
func test():
print("Cannot use @onready without a Node base")

2
modules/gdscript/tests/scripts/analyzer/errors/onready_within_non_node_inner_class.out Normal file
View file

@ -0,0 +1,2 @@
GDTEST_ANALYZER_ERROR
"@onready" can only be used in classes that inherit "Node".

7
modules/gdscript/tests/scripts/analyzer/features/onready_on_inner_class_with_non_node_outer.gd Normal file
View file

@ -0,0 +1,7 @@
extends RefCounted
func test():
print("ok")
class Inner extends Node:
@onready var okay = 0

2
modules/gdscript/tests/scripts/analyzer/features/onready_on_inner_class_with_non_node_outer.out Normal file
View file

@ -0,0 +1,2 @@
GDTEST_OK
ok