ladybird/Userland/Applications/SoundPlayer/VisualizationWidget.h

/*
 * Copyright (c) 2021, Cesar Torres <shortanemoia@protonmail.com>
 *
 * SPDX-License-Identifier: BSD-2-Clause
 */

#pragma once

#include <LibAudio/Buffer.h>
#include <LibGUI/Frame.h>

class VisualizationWidget : public GUI::Frame {
    C_OBJECT(VisualizationWidget)

public:
    virtual void set_buffer(RefPtr<Audio::Buffer> buffer) = 0;
    virtual void set_samplerate(int) { }

protected:
    VisualizationWidget() = default;
    virtual ~VisualizationWidget() = default;
};
SoundPlayer: Add abstractions for players and visulizations This can make them easier to be swappable in realtime 2021-03-21 12:49:14 +01:00			`/*`
			`* Copyright (c) 2021, Cesar Torres <shortanemoia@protonmail.com>`
			`*`
Everything: Move to SPDX license identifiers in all files. SPDX License Identifiers are a more compact / standardized way of representing file license information. See: https://spdx.dev/resources/use/#identifiers This was done with the `ambr` search and replace tool. ambr --no-parent-ignore --key-from-file --rep-from-file key.txt rep.txt * 2021-04-22 01:24:48 -07:00			`* SPDX-License-Identifier: BSD-2-Clause`
SoundPlayer: Add abstractions for players and visulizations This can make them easier to be swappable in realtime 2021-03-21 12:49:14 +01:00			`*/`

			`#pragma once`

			`#include <LibAudio/Buffer.h>`
SoundPlayer: Fix inconsistencies and code duplication This is a first pass at refactoring SoundPlayer so that the View widget is decoupled from the player itself. In doing so, this fixed a couple of issues, including possibly inconsistent states (e.g. player could be paused and stopped at the same time). With the change, Player actually controls the show, and calls methods overriden by its subclasses to perform actions, such as update the Seek bar; the hard work of massaging the raw data is done by the Player class, so subclasses don't need to reimplement any of these things. This also removes some copies of playlist management code that happened to be copied+pasted inside callbacks of buttons -- it now lives inside a neatly packaged Playlist class, and the Player only asks for the next song to play. In addition, the menu bar has been slightly rearranged. 2021-09-29 21:55:42 -07:00			`#include <LibGUI/Frame.h>`

			`class VisualizationWidget : public GUI::Frame {`
			`C_OBJECT(VisualizationWidget)`
SoundPlayer: Add abstractions for players and visulizations This can make them easier to be swappable in realtime 2021-03-21 12:49:14 +01:00
			`public:`
			`virtual void set_buffer(RefPtr<Audio::Buffer> buffer) = 0;`
SoundPlayer: Add samplerate variable to visualizations also fix conflict 2021-03-26 01:28:56 +01:00			`virtual void set_samplerate(int) { }`
Everything: Add `-Wnon-virtual-dtor` flag This flag warns on classes which have `virtual` functions but do not have a `virtual` destructor. This patch adds both the flag and missing destructors. The access level of the destructors was determined by a two rules of thumb: 1. A destructor should have a similar or lower access level to that of a constructor. 2. Having a `private` destructor implicitly deletes the default constructor, which is probably undesirable for "interface" types (classes with only virtual functions and no data). In short, most of the added destructors are `protected`, unless the compiler complained about access. 2021-04-15 10:43:29 -07:00
			`protected:`
Applications: Fix visibility of Object-derivative constructors Derivatives of Core::Object should be constructed through ClassName::construct(), to avoid handling ref-counted objects with refcount zero. Fixing the visibility means that misuses like this are more difficult. 2021-10-31 23:38:04 +01:00			`VisualizationWidget() = default;`
SoundPlayer: Fix inconsistencies and code duplication This is a first pass at refactoring SoundPlayer so that the View widget is decoupled from the player itself. In doing so, this fixed a couple of issues, including possibly inconsistent states (e.g. player could be paused and stopped at the same time). With the change, Player actually controls the show, and calls methods overriden by its subclasses to perform actions, such as update the Seek bar; the hard work of massaging the raw data is done by the Player class, so subclasses don't need to reimplement any of these things. This also removes some copies of playlist management code that happened to be copied+pasted inside callbacks of buttons -- it now lives inside a neatly packaged Playlist class, and the Player only asks for the next song to play. In addition, the menu bar has been slightly rearranged. 2021-09-29 21:55:42 -07:00			`virtual ~VisualizationWidget() = default;`
SoundPlayer: Add abstractions for players and visulizations This can make them easier to be swappable in realtime 2021-03-21 12:49:14 +01:00			`};`