From 095eb8194e057debb33049275b8864d6ce9eb995 Mon Sep 17 00:00:00 2001 From: Tim Schumacher Date: Fri, 3 Jun 2022 16:46:28 +0200 Subject: [PATCH] Ports: Replace manually linking `libksba` with a libtool patch --- Ports/libksba/package.sh | 6 -- ...hared-library-support-for-SerenityOS.patch | 76 +++++++++++++++++++ Ports/libksba/patches/ReadMe.md | 16 ++++ 3 files changed, 92 insertions(+), 6 deletions(-) create mode 100644 Ports/libksba/patches/0001-libtool-Enable-shared-library-support-for-SerenityOS.patch create mode 100644 Ports/libksba/patches/ReadMe.md diff --git a/Ports/libksba/package.sh b/Ports/libksba/package.sh index 307515d981d..51504ac6f85 100755 --- a/Ports/libksba/package.sh +++ b/Ports/libksba/package.sh @@ -15,9 +15,3 @@ pre_configure() { configure() { run ./configure --host="${SERENITY_ARCH}-pc-serenity" --build="$($workdir/build-aux/config.guess)" "${configopts[@]}" } - -install() { - run make DESTDIR=${SERENITY_INSTALL_ROOT} "${installopts[@]}" install - ${CC} -shared -o ${SERENITY_INSTALL_ROOT}/usr/local/lib/libksba.so -Wl,-soname,libksba.so -Wl,--whole-archive ${SERENITY_INSTALL_ROOT}/usr/local/lib/libksba.a -Wl,--no-whole-archive -lgpg-error - rm -f ${SERENITY_INSTALL_ROOT}/usr/local/lib/libksba.la -} diff --git a/Ports/libksba/patches/0001-libtool-Enable-shared-library-support-for-SerenityOS.patch b/Ports/libksba/patches/0001-libtool-Enable-shared-library-support-for-SerenityOS.patch new file mode 100644 index 00000000000..d486dd11d6e --- /dev/null +++ b/Ports/libksba/patches/0001-libtool-Enable-shared-library-support-for-SerenityOS.patch @@ -0,0 +1,76 @@ +From 253d1b4ca2d00e63cf66fcd04794ff7d85ca4013 Mon Sep 17 00:00:00 2001 +From: Tim Schumacher +Date: Sun, 29 May 2022 15:01:28 +0200 +Subject: [PATCH] libtool: Enable shared library support for SerenityOS + +For some odd reason, libtool handles the configuration for shared +libraries entirely statically and in its configure script. If no +shared library support is "present", building shared libraries is +disabled entirely. + +Fix that by just adding the appropriate configuration options for +`serenity`. This allows us to finally create dynamic libraries +automatically using libtool, without having to manually link the +static library into a shared library. +--- + configure | 23 +++++++++++++++++++++++ + 1 file changed, 23 insertions(+) + +diff --git a/configure b/configure +index e9b010b..964315e 100755 +--- a/configure ++++ b/configure +@@ -5986,6 +5986,10 @@ sysv4 | sysv4.3*) + tpf*) + lt_cv_deplibs_check_method=pass_all + ;; ++ ++serenity*) ++ lt_cv_deplibs_check_method=pass_all ++ ;; + esac + + fi +@@ -9015,6 +9019,10 @@ lt_prog_compiler_static= + lt_prog_compiler_static='-Bstatic' + ;; + ++ serenity*) ++ lt_prog_compiler_can_build_shared=yes ++ ;; ++ + *) + lt_prog_compiler_can_build_shared=no + ;; +@@ -10431,6 +10439,10 @@ $as_echo "$lt_cv_irix_exported_symbol" >&6; } + hardcode_shlibpath_var=no + ;; + ++ serenity*) ++ ld_shlibs=yes ++ ;; ++ + *) + ld_shlibs=no + ;; +@@ -11446,6 +11458,17 @@ uts4*) + shlibpath_var=LD_LIBRARY_PATH + ;; + ++serenity*) ++ version_type=linux ++ need_lib_prefix=no ++ need_version=no ++ library_names_spec='${libname}${release}${shared_ext}${versuffix} ${libname}${release}${shared_ext}${major} ${libname}${shared_ext}' ++ soname_spec='${libname}${release}${shared_ext}${major}' ++ shlibpath_var=LD_LIBRARY_PATH ++ shlibpath_overrides_runpath=no ++ dynamic_linker='SerenityOS LibELF' ++ ;; ++ + *) + dynamic_linker=no + ;; +-- +2.36.1 + diff --git a/Ports/libksba/patches/ReadMe.md b/Ports/libksba/patches/ReadMe.md new file mode 100644 index 00000000000..b42917974cb --- /dev/null +++ b/Ports/libksba/patches/ReadMe.md @@ -0,0 +1,16 @@ +# Patches for libksba on SerenityOS + +## `0001-libtool-Enable-shared-library-support-for-SerenityOS.patch` + +libtool: Enable shared library support for SerenityOS + +For some odd reason, libtool handles the configuration for shared +libraries entirely statically and in its configure script. If no +shared library support is "present", building shared libraries is +disabled entirely. + +Fix that by just adding the appropriate configuration options for +`serenity`. This allows us to finally create dynamic libraries +automatically using libtool, without having to manually link the +static library into a shared library. +