mirrors/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-01-24 02:03:06 -05:00
Code Issues Projects Releases Packages Wiki Activity

LibWeb: Check if scripting is disabled before running script

Browse source 
This is not a full check, it's just enough to prevent script execution
in DOMParser.
This commit is contained in:
Luke 2021-07-05 03:59:47 +01:00 • committed by Andreas Kling
parent ce314c54bd
commit 0ea50d44bf
Notes: sideshowbarker 2024-07-18 10:24:40 +09:00
3 changed files with 13 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
Userland/Libraries/LibWeb/DOM/Node.cpp
View file

@ -637,4 +637,11 @@ void Node::serialize_tree_as_json(JsonObjectSerializer<StringBuilder>& object) c
}
}
// https://html.spec.whatwg.org/multipage/webappapis.html#concept-n-noscript
bool Node::is_scripting_disabled() const
{
// FIXME: or when scripting is disabled for its relevant settings object.
return !document().browsing_context();
}
}

2
Userland/Libraries/LibWeb/DOM/Node.h
View file

@ -163,6 +163,8 @@ public:
bool is_host_including_inclusive_ancestor_of(const Node&) const;
bool is_scripting_disabled() const;
// Used for dumping the DOM Tree
void serialize_tree_as_json(JsonObjectSerializer<StringBuilder>&) const;

5
Userland/Libraries/LibWeb/HTML/HTMLScriptElement.cpp
View file

@ -153,7 +153,10 @@ void HTMLScriptElement::prepare_script()
return;
}
// FIXME: Check if scripting is disabled, if so return
if (is_scripting_disabled()) {
dbgln("HTMLScriptElement: Refusing to run script because scripting is disabled.");
return;
}
if (m_script_type == ScriptType::Classic && has_attribute(HTML::AttributeNames::nomodule)) {
dbgln("HTMLScriptElement: Refusing to run classic script because it has the nomodule attribute.");