mirrors/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-01-22 17:24:48 -05:00
Code Issues Projects Releases Packages Wiki Activity

LibWeb/DOM: Remove uneccessary ExceptionOr for NodeIterator::create

Browse source
This commit is contained in:
Shannon Booth 2025-01-10 16:12:34 +13:00 committed by Sam Atkins
parent 17c92d7c2b
commit 1f4c7ac62b
Notes: github-actions[bot] 2025-01-10 08:09:47 +00:00 
Author: https://github.com/shannonbooth
Commit: https://github.com/LadybirdBrowser/ladybird/commit/1f4c7ac62b3
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/3208
Reviewed-by: https://github.com/AtkinsSJ ✅
3 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
Libraries/LibWeb/DOM/Document.cpp
View file

@ -3336,7 +3336,7 @@ WebIDL::ExceptionOr<Document::PrefixAndTagName> Document::validate_qualified_nam
// https://dom.spec.whatwg.org/#dom-document-createnodeiterator // https://dom.spec.whatwg.org/#dom-document-createnodeiterator
GC::Ref<NodeIterator> Document::create_node_iterator(Node& root, unsigned what_to_show, GC::Ptr<NodeFilter> filter) GC::Ref<NodeIterator> Document::create_node_iterator(Node& root, unsigned what_to_show, GC::Ptr<NodeFilter> filter)
{ {
return NodeIterator::create(realm(), root, what_to_show, filter).release_value_but_fixme_should_propagate_errors(); return NodeIterator::create(realm(), root, what_to_show, filter);
} }
// https://dom.spec.whatwg.org/#dom-document-createtreewalker // https://dom.spec.whatwg.org/#dom-document-createtreewalker

2
Libraries/LibWeb/DOM/NodeIterator.cpp
View file

@ -48,7 +48,7 @@ void NodeIterator::visit_edges(Cell::Visitor& visitor)
} }
// https://dom.spec.whatwg.org/#dom-document-createnodeiterator // https://dom.spec.whatwg.org/#dom-document-createnodeiterator
WebIDL::ExceptionOr<GC::Ref<NodeIterator>> NodeIterator::create(JS::Realm& realm, Node& root, unsigned what_to_show, GC::Ptr<NodeFilter> filter) GC::Ref<NodeIterator> NodeIterator::create(JS::Realm& realm, Node& root, unsigned what_to_show, GC::Ptr<NodeFilter> filter)
{ {
// 1. Let iterator be a new NodeIterator object. // 1. Let iterator be a new NodeIterator object.
// 2. Set iterator’s root and iterator’s reference to root. // 2. Set iterator’s root and iterator’s reference to root.

2
Libraries/LibWeb/DOM/NodeIterator.h
View file

@ -17,7 +17,7 @@ class NodeIterator final : public Bindings::PlatformObject {
GC_DECLARE_ALLOCATOR(NodeIterator); GC_DECLARE_ALLOCATOR(NodeIterator);
public: public:
static WebIDL::ExceptionOr<GC::Ref<NodeIterator>> create(JS::Realm& realm, Node& root, unsigned what_to_show, GC::Ptr<NodeFilter>); static GC::Ref<NodeIterator> create(JS::Realm& realm, Node& root, unsigned what_to_show, GC::Ptr<NodeFilter>);
virtual ~NodeIterator() override; virtual ~NodeIterator() override;