mirrors/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-01-22 17:24:48 -05:00
Code Issues Projects Releases Packages Wiki Activity

LibWeb: Assign “orphaned” li elements the default ARIA role “none”

Browse source 
This change makes Ladybird conform to the current requirements at
https://w3c.github.io/core-aam/#roleMappingComputedRole in the “Core
Accessibility API Mappings” spec for the case of “orphaned” li elements;
that is, any li element which doesn’t have a role=list ancestor.

The core-aam spec requires that in such cases, the li element must not
be assigned the “listitem” role but instead must be treated as if it had
no role at all.
This commit is contained in:
sideshowbarker 2024-12-09 17:01:54 +09:00 committed by Andrew Kaster
parent 824e91ffdb
commit 2d638485a8
Notes: github-actions[bot] 2024-12-11 23:56:09 +00:00 
Author: https://github.com/sideshowbarker
Commit: https://github.com/LadybirdBrowser/ladybird/commit/2d638485a89
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/2847
Reviewed-by: https://github.com/ADKaster ✅
Reviewed-by: https://github.com/gmta
Reviewed-by: https://github.com/tcl3
3 changed files with 42 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
Libraries/LibWeb/HTML/HTMLLIElement.h
View file

@ -6,8 +6,10 @@
#pragma once
#include <LibWeb/ARIA/Roles.h>
#include <AK/GenericShorthands.h>
#include <LibWeb/HTML/HTMLElement.h>
#include <LibWeb/HTML/HTMLOListElement.h>
#include <LibWeb/HTML/HTMLUListElement.h>
#include <LibWeb/WebIDL/Types.h>
namespace Web::HTML {
@ -20,7 +22,18 @@ public:
virtual ~HTMLLIElement() override;
// https://www.w3.org/TR/html-aria/#el-li
virtual Optional<ARIA::Role> default_role() const override { return ARIA::Role::listitem; }
virtual Optional<ARIA::Role> default_role() const override
{
for (auto const* ancestor = parent_element(); ancestor; ancestor = ancestor->parent_element()) {
if (ancestor->role_or_default() == ARIA::Role::list)
return ARIA::Role::listitem;
}
// https://w3c.github.io/core-aam/#roleMappingComputedRole
// When an element has a role but is not contained in the required context (for example, an orphaned listitem
// without the required accessible parent of role list), User Agents MUST ignore the role token, and return the
// computedrole as if the ignored role token had not been included.
return ARIA::Role::none;
}
WebIDL::Long value();
void set_value(WebIDL::Long value)

6
Tests/LibWeb/Text/expected/wpt-import/html-aam/roles-generic.tentative.txt Normal file
View file

@ -0,0 +1,6 @@
Harness status: OK
Found 1 tests
1 Pass
Pass el-li-orphaned

21
Tests/LibWeb/Text/input/wpt-import/html-aam/roles-generic.tentative.html Normal file
View file

@ -0,0 +1,21 @@
<!doctype html>
<html>
<head>
<title>Tentative: HTML-AAM Generic Role Verification Tests</title>
<script src="../resources/testharness.js"></script>
<script src="../resources/testharnessreport.js"></script>
<script src="../resources/testdriver.js"></script>
<script src="../resources/testdriver-vendor.js"></script>
<script src="../resources/testdriver-actions.js"></script>
<script src="../wai-aria/scripts/aria-utils.js"></script>
</head>
<body>
<li data-testname="el-li-orphaned" class="ex-generic">x</li><!-- todo: should orphaned roles be tested in a new ./roles-orphaned.html file? -->
<script>
AriaUtils.verifyGenericRolesBySelector(".ex-generic");
</script>
</body>
</html>