mirrors/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-01-22 09:12:13 -05:00
Code Issues Projects Releases Packages Wiki Activity

LibWeb: Remove unnecessary condition from editing delete action

Browse source
This commit is contained in:
Jelle Raaijmakers 2024-12-20 11:39:50 +01:00 committed by Jelle Raaijmakers
parent ff25d66dae
commit 30a3fe8387
Notes: github-actions[bot] 2024-12-21 18:17:02 +00:00 
Author: https://github.com/gmta
Commit: https://github.com/LadybirdBrowser/ladybird/commit/30a3fe8387f
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/2991
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
Libraries/LibWeb/Editing/Commands.cpp
View file

@ -293,12 +293,12 @@ bool command_delete_action(DOM::Document& document, String const&)
// 14. If the child of start node with index start offset is an li or dt or dd, and that child's
// firstChild is an inline node, and start offset is not zero:
// NOTE: step 9 above guarantees start_offset cannot be 0 here.
auto is_li_dt_or_dd = [](DOM::Element const& node) {
return node.local_name().is_one_of(HTML::TagNames::li, HTML::TagNames::dt, HTML::TagNames::dd);
};
auto* start_offset_child = start_node->child_at_index(start_offset);
if (start_offset != 0 && is<DOM::Element>(start_offset_child)
&& is_li_dt_or_dd(static_cast<DOM::Element&>(*start_offset_child))
if (is<DOM::Element>(start_offset_child) && is_li_dt_or_dd(static_cast<DOM::Element&>(*start_offset_child))
&& start_offset_child->has_children() && is_inline_node(*start_offset_child->first_child())) {
// 1. Let previous item be the child of start node with index start offset minus one.
GC::Ref<DOM::Node> previous_item = *start_node->child_at_index(start_offset - 1);