mirrors/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-01-22 09:12:13 -05:00
Code Issues Projects Releases Packages Wiki Activity

Meta: Add a --debug-process option to WPT.sh

Browse source 
This passes the `--debug-process` option to WebDriver.
This commit is contained in:
Tim Ledbetter 2024-12-12 11:47:39 +00:00 committed by Jelle Raaijmakers
parent 2528055703
commit 34f78ca152
Notes: github-actions[bot] 2024-12-20 22:43:00 +00:00 
Author: https://github.com/tcl3
Commit: https://github.com/LadybirdBrowser/ladybird/commit/34f78ca1522
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/2886
Reviewed-by: https://github.com/gmta
2 changed files with 8 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
Meta/WPT.sh
View file

@ -72,6 +72,8 @@ print_help() {
Run the Web Platform Tests in the 'css' and 'dom' directories and save the output to expectations.log.
$NAME run --log-wptreport expectations.json --log-wptscreenshot expectations.db css dom
Run the Web Platform Tests in the 'css' and 'dom' directories; save the output in wptreport format to expectations.json and save screenshots to expectations.db.
$NAME run --debug-process WebContent http://wpt.live/dom/historical.html
Run the 'dom/historical.html' test, attaching the debugger to the WebContent process when the browser is launched.
$NAME compare expectations.log
Run all of the Web Platform Tests comparing the results to the expectations in before.log.
$NAME compare --log results.log expectations.log css/CSS2
@ -109,11 +111,16 @@ set_logging_flags()
headless=1
ARG=$1
while [[ "$ARG" =~ ^(--show-window|(--log(-(raw|unittest|xunit|html|mach|tbpl|grouped|chromium|wptreport|wptscreenshot))?))$ ]]; do
while [[ "$ARG" =~ ^(--show-window|--debug-process|(--log(-(raw|unittest|xunit|html|mach|tbpl|grouped|chromium|wptreport|wptscreenshot))?))$ ]]; do
case "$ARG" in
--show-window)
headless=0
;;
--debug-process)
process_name="${2}"
shift
WPT_ARGS+=( "--webdriver-arg=--debug-process=${process_name}" )
;;
--log)
set_logging_flags "--log-raw" "${2}"
shift

1
Services/WebDriver/main.cpp
View file

@ -52,7 +52,6 @@ static Vector<ByteString> create_arguments(ByteString const& socket_path, bool f
if (force_cpu_painting)
arguments.append("--force-cpu-painting"sv);
dbgln("Debug process: {}", debug_process);
if (debug_process.has_value())
arguments.append(ByteString::formatted("--debug-process={}", debug_process.value()));