mirrors/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-01-22 09:12:13 -05:00
Code Issues Projects Releases Packages Wiki Activity

LibWeb: Send cookies in the WebSocket handshake

Browse source 
This allows Figma WebSockets to authenticate the user.
This commit is contained in:
Luke Wilde 2025-01-09 16:29:08 +00:00 committed by Andreas Kling
parent f3f51f2547
commit 513231216a
Notes: github-actions[bot] 2025-01-21 20:38:47 +00:00 
Author: https://github.com/Lubrsi
Commit: https://github.com/LadybirdBrowser/ladybird/commit/513231216ab
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/3239
Reviewed-by: https://github.com/awesomekling
Reviewed-by: https://github.com/kalenikaliaksandr
1 changed files with 18 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
Libraries/LibWeb/WebSockets/WebSocket.cpp
View file

@ -10,6 +10,7 @@
#include <LibJS/Runtime/FunctionObject.h>
#include <LibRequests/RequestClient.h>
#include <LibURL/Origin.h>
#include <LibWeb/Bindings/PrincipalHostDefined.h>
#include <LibWeb/Bindings/WebSocketPrototype.h>
#include <LibWeb/DOM/Document.h>
#include <LibWeb/DOM/Event.h>
@ -130,7 +131,23 @@ ErrorOr<void> WebSocket::establish_web_socket_connection(URL::URL& url_record, V
for (auto const& protocol : protocols)
TRY(protcol_byte_strings.try_append(protocol.to_byte_string()));
m_websocket = ResourceLoader::the().request_client().websocket_connect(url_record, origin_string, protcol_byte_strings);
HTTP::HeaderMap additional_headers;
auto cookies = ([&] {
// FIXME: Getting to the page client reliably is way too complicated, and going via the document won't work in workers.
auto document = client.responsible_document();
if (!document)
return String {};
// NOTE: The WebSocket handshake is sent as an HTTP request, so the source should be Http.
return document->page().client().page_did_request_cookie(url_record, Cookie::Source::Http);
})();
if (!cookies.is_empty()) {
additional_headers.set("Cookie", cookies.to_byte_string());
}
m_websocket = ResourceLoader::the().request_client().websocket_connect(url_record, origin_string, protcol_byte_strings, {}, additional_headers);
m_websocket->on_open = [weak_this = make_weak_ptr<WebSocket>()] {
if (!weak_this)