mirrors/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-01-23 01:32:14 -05:00
Code Issues Projects Releases Packages Wiki Activity

LibCompress: Add another unit test.

Browse source 
I suspected an error in CircularDuplexStream::read(Bytes, size_t). This
does not appear to be the case, this test case is useful regardless.

The following script was used to generate the test:

    import gzip

    uncompressed = []
    for _ in range(0x100):
        uncompressed.append(1)
    for _ in range(0x7e00):
        uncompressed.append(0)
    for _ in range(0x100):
        uncompressed.append(1)

    compressed = gzip.compress(bytes(uncompressed))
    compressed = ", ".join(f"0x{byte:02x}" for byte in compressed)

    print(f"""\
    TEST_CASE(gzip_decompress_repeat_around_buffer)
    {{
        const u8 compressed[] = {{
            {compressed}
        }};

        u8 uncompressed[0x8011];
        Bytes{{ uncompressed, sizeof(uncompressed) }}.fill(0);
        uncompressed[0x8000] = 1;

        const auto decompressed = Compress::GzipDecompressor::decompress_all({{ compressed, sizeof(compressed) }});

        EXPECT(compare({{ uncompressed, sizeof(uncompressed) }}, decompressed.bytes()));
    }}
    """, end="")
This commit is contained in:
asynts 2020-09-05 13:18:01 +02:00 committed by Andreas Kling
parent e2e2e782d4
commit 5d85be7ed4
Notes: sideshowbarker 2024-07-19 02:53:47 +09:00 
Author: https://github.com/asynts
Commit: https://github.com/SerenityOS/serenity/commit/5d85be7ed46
Pull-request: https://github.com/SerenityOS/serenity/pull/3405
2 changed files with 23 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
Libraries/LibCompress/Gzip.cpp
View file

@ -78,6 +78,8 @@ size_t GzipDecompressor::read(Bytes bytes)
m_input_stream >> crc32 >> input_size; m_input_stream >> crc32 >> input_size;
if (crc32 != current_member().m_checksum.digest()) { if (crc32 != current_member().m_checksum.digest()) {
// FIXME: Somehow the checksum is incorrect?
set_fatal_error(); set_fatal_error();
return 0; return 0;
} }

24
Userland/test-compress.cpp
View file

@ -26,6 +26,7 @@
#include <AK/TestSuite.h> #include <AK/TestSuite.h>
#include <AK/FixedArray.h>
#include <LibCompress/Deflate.h> #include <LibCompress/Deflate.h>
#include <LibCompress/Gzip.h> #include <LibCompress/Gzip.h>
#include <LibCompress/Zlib.h> #include <LibCompress/Zlib.h>
@ -127,7 +128,6 @@ TEST_CASE(gzip_decompress_simple)
const u8 uncompressed[] = "word1 abc word2"; const u8 uncompressed[] = "word1 abc word2";
const auto decompressed = Compress::GzipDecompressor::decompress_all({ compressed, sizeof(compressed) }); const auto decompressed = Compress::GzipDecompressor::decompress_all({ compressed, sizeof(compressed) });
EXPECT(compare({ uncompressed, sizeof(uncompressed) - 1 }, decompressed.bytes())); EXPECT(compare({ uncompressed, sizeof(uncompressed) - 1 }, decompressed.bytes()));
} }
@ -145,7 +145,6 @@ TEST_CASE(gzip_decompress_multiple_members)
const u8 uncompressed[] = "abcabcabcabc"; const u8 uncompressed[] = "abcabcabcabc";
const auto decompressed = Compress::GzipDecompressor::decompress_all({ compressed, sizeof(compressed) }); const auto decompressed = Compress::GzipDecompressor::decompress_all({ compressed, sizeof(compressed) });
EXPECT(compare({ uncompressed, sizeof(uncompressed) - 1 }, decompressed.bytes())); EXPECT(compare({ uncompressed, sizeof(uncompressed) - 1 }, decompressed.bytes()));
} }
@ -171,8 +170,27 @@ TEST_CASE(gzip_decompress_zeroes)
const u8 uncompressed[128 * 1024] = { 0 }; const u8 uncompressed[128 * 1024] = { 0 };
const auto decompressed = Compress::GzipDecompressor::decompress_all({ compressed, sizeof(compressed) }); const auto decompressed = Compress::GzipDecompressor::decompress_all({ compressed, sizeof(compressed) });
EXPECT(compare({ uncompressed, sizeof(uncompressed) }, decompressed.bytes())); EXPECT(compare({ uncompressed, sizeof(uncompressed) }, decompressed.bytes()));
} }
TEST_CASE(gzip_decompress_repeat_around_buffer)
{
const u8 compressed[] = {
0x1f, 0x8b, 0x08, 0x00, 0xc6, 0x74, 0x53, 0x5f, 0x02, 0xff, 0xed, 0xc1,
0x01, 0x0d, 0x00, 0x00, 0x0c, 0x02, 0xa0, 0xdb, 0xbf, 0xf4, 0x37, 0x6b,
0x08, 0x24, 0xdb, 0x0e, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x80, 0xca,
0xb8, 0x07, 0xcd, 0xe5, 0x38, 0xfa, 0x00, 0x80, 0x00, 0x00
};
FixedArray<u8> uncompressed { 0x8000 };
uncompressed.bytes().slice(0x0, 0x100).fill(1);
uncompressed.bytes().slice(0x100, 0x7e00).fill(0);
uncompressed.bytes().slice(0x7f00, 0x100).fill(1);
const auto decompressed = Compress::GzipDecompressor::decompress_all({ compressed, sizeof(compressed) });
EXPECT(compare(uncompressed, decompressed.bytes()));
}
TEST_MAIN(Compress) TEST_MAIN(Compress)