mirror of
https://github.com/LadybirdBrowser/ladybird.git
synced 2025-01-22 17:24:48 -05:00
LibWeb/CSS: Sort text-decoration-line values in spec order
This wins us 49 WPT subtest passes! :^)
This commit is contained in:
Sam Atkins
Andreas Kling
parent
fa1e102f3c
commit
671d3e8a48
Notes:
github-actions[bot]
2024-11-30 10:02:36 +00:00
Author: https://github.com/AtkinsSJ Commit: https://github.com/LadybirdBrowser/ladybird/commit/671d3e8a48d Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/2638
3 changed files with 59 additions and 54 deletions
|
|
@ -439,11 +439,11 @@
|
|||
"-libweb-right"
|
||||
],
|
||||
"text-decoration-line": [
|
||||
"blink",
|
||||
"line-through",
|
||||
"none",
|
||||
"underline",
|
||||
"overline",
|
||||
"underline"
|
||||
"line-through",
|
||||
"blink"
|
||||
],
|
||||
"text-decoration-style": [
|
||||
"dashed",
|
||||
|
|
|
|||
|
|
@ -6384,6 +6384,11 @@ RefPtr<CSSStyleValue> Parser::parse_text_decoration_line_value(TokenStream<Compo
|
|||
|
||||
if (style_values.is_empty())
|
||||
return nullptr;
|
||||
|
||||
quick_sort(style_values, [](auto& left, auto& right) {
|
||||
return *keyword_to_text_decoration_line(left->to_keyword()) < *keyword_to_text_decoration_line(right->to_keyword());
|
||||
});
|
||||
|
||||
return StyleValueList::create(move(style_values), StyleValueList::Separator::Space);
|
||||
}
|
||||
|
||||
|
|
|
|||
|
|
@ -6,8 +6,8 @@ Rerun
|
|||
|
||||
Found 67 tests
|
||||
|
||||
16 Pass
|
||||
51 Fail
|
||||
65 Pass
|
||||
2 Fail
|
||||
Details
|
||||
Result Test Name MessagePass e.style['text-decoration-line'] = "none" should set the property value
|
||||
Pass e.style['text-decoration-line'] = "underline" should set the property value
|
||||
|
|
@ -15,64 +15,64 @@ Pass e.style['text-decoration-line'] = "overline" should set the property value
|
|||
Pass e.style['text-decoration-line'] = "line-through" should set the property value
|
||||
Pass e.style['text-decoration-line'] = "blink" should set the property value
|
||||
Pass e.style['text-decoration-line'] = "underline overline" should set the property value
|
||||
Fail e.style['text-decoration-line'] = "overline underline" should set the property value
|
||||
Pass e.style['text-decoration-line'] = "overline underline" should set the property value
|
||||
Pass e.style['text-decoration-line'] = "underline line-through" should set the property value
|
||||
Fail e.style['text-decoration-line'] = "line-through underline" should set the property value
|
||||
Pass e.style['text-decoration-line'] = "line-through underline" should set the property value
|
||||
Pass e.style['text-decoration-line'] = "underline blink" should set the property value
|
||||
Fail e.style['text-decoration-line'] = "blink underline" should set the property value
|
||||
Pass e.style['text-decoration-line'] = "blink underline" should set the property value
|
||||
Pass e.style['text-decoration-line'] = "overline line-through" should set the property value
|
||||
Fail e.style['text-decoration-line'] = "line-through overline" should set the property value
|
||||
Pass e.style['text-decoration-line'] = "line-through overline" should set the property value
|
||||
Pass e.style['text-decoration-line'] = "overline blink" should set the property value
|
||||
Fail e.style['text-decoration-line'] = "blink overline" should set the property value
|
||||
Pass e.style['text-decoration-line'] = "blink overline" should set the property value
|
||||
Pass e.style['text-decoration-line'] = "line-through blink" should set the property value
|
||||
Fail e.style['text-decoration-line'] = "blink line-through" should set the property value
|
||||
Pass e.style['text-decoration-line'] = "blink line-through" should set the property value
|
||||
Pass e.style['text-decoration-line'] = "underline overline line-through" should set the property value
|
||||
Fail e.style['text-decoration-line'] = "underline line-through overline" should set the property value
|
||||
Fail e.style['text-decoration-line'] = "overline underline line-through" should set the property value
|
||||
Fail e.style['text-decoration-line'] = "overline line-through underline" should set the property value
|
||||
Fail e.style['text-decoration-line'] = "line-through underline overline" should set the property value
|
||||
Fail e.style['text-decoration-line'] = "line-through overline underline" should set the property value
|
||||
Pass e.style['text-decoration-line'] = "underline line-through overline" should set the property value
|
||||
Pass e.style['text-decoration-line'] = "overline underline line-through" should set the property value
|
||||
Pass e.style['text-decoration-line'] = "overline line-through underline" should set the property value
|
||||
Pass e.style['text-decoration-line'] = "line-through underline overline" should set the property value
|
||||
Pass e.style['text-decoration-line'] = "line-through overline underline" should set the property value
|
||||
Pass e.style['text-decoration-line'] = "underline overline blink" should set the property value
|
||||
Fail e.style['text-decoration-line'] = "underline blink overline" should set the property value
|
||||
Fail e.style['text-decoration-line'] = "overline underline blink" should set the property value
|
||||
Fail e.style['text-decoration-line'] = "overline blink underline" should set the property value
|
||||
Fail e.style['text-decoration-line'] = "blink underline overline" should set the property value
|
||||
Fail e.style['text-decoration-line'] = "blink overline underline" should set the property value
|
||||
Pass e.style['text-decoration-line'] = "underline blink overline" should set the property value
|
||||
Pass e.style['text-decoration-line'] = "overline underline blink" should set the property value
|
||||
Pass e.style['text-decoration-line'] = "overline blink underline" should set the property value
|
||||
Pass e.style['text-decoration-line'] = "blink underline overline" should set the property value
|
||||
Pass e.style['text-decoration-line'] = "blink overline underline" should set the property value
|
||||
Pass e.style['text-decoration-line'] = "underline line-through blink" should set the property value
|
||||
Fail e.style['text-decoration-line'] = "underline blink line-through" should set the property value
|
||||
Fail e.style['text-decoration-line'] = "line-through underline blink" should set the property value
|
||||
Fail e.style['text-decoration-line'] = "line-through blink underline" should set the property value
|
||||
Fail e.style['text-decoration-line'] = "blink underline line-through" should set the property value
|
||||
Fail e.style['text-decoration-line'] = "blink line-through underline" should set the property value
|
||||
Pass e.style['text-decoration-line'] = "underline blink line-through" should set the property value
|
||||
Pass e.style['text-decoration-line'] = "line-through underline blink" should set the property value
|
||||
Pass e.style['text-decoration-line'] = "line-through blink underline" should set the property value
|
||||
Pass e.style['text-decoration-line'] = "blink underline line-through" should set the property value
|
||||
Pass e.style['text-decoration-line'] = "blink line-through underline" should set the property value
|
||||
Pass e.style['text-decoration-line'] = "overline line-through blink" should set the property value
|
||||
Fail e.style['text-decoration-line'] = "overline blink line-through" should set the property value
|
||||
Fail e.style['text-decoration-line'] = "line-through overline blink" should set the property value
|
||||
Fail e.style['text-decoration-line'] = "line-through blink overline" should set the property value
|
||||
Fail e.style['text-decoration-line'] = "blink overline line-through" should set the property value
|
||||
Fail e.style['text-decoration-line'] = "blink line-through overline" should set the property value
|
||||
Pass e.style['text-decoration-line'] = "overline blink line-through" should set the property value
|
||||
Pass e.style['text-decoration-line'] = "line-through overline blink" should set the property value
|
||||
Pass e.style['text-decoration-line'] = "line-through blink overline" should set the property value
|
||||
Pass e.style['text-decoration-line'] = "blink overline line-through" should set the property value
|
||||
Pass e.style['text-decoration-line'] = "blink line-through overline" should set the property value
|
||||
Pass e.style['text-decoration-line'] = "underline overline line-through blink" should set the property value
|
||||
Fail e.style['text-decoration-line'] = "underline overline blink line-through" should set the property value
|
||||
Fail e.style['text-decoration-line'] = "underline line-through overline blink" should set the property value
|
||||
Fail e.style['text-decoration-line'] = "underline line-through blink overline" should set the property value
|
||||
Fail e.style['text-decoration-line'] = "underline blink overline line-through" should set the property value
|
||||
Fail e.style['text-decoration-line'] = "underline blink line-through overline" should set the property value
|
||||
Fail e.style['text-decoration-line'] = "overline underline line-through blink" should set the property value
|
||||
Fail e.style['text-decoration-line'] = "overline underline blink line-through" should set the property value
|
||||
Fail e.style['text-decoration-line'] = "overline line-through underline blink" should set the property value
|
||||
Fail e.style['text-decoration-line'] = "overline line-through blink underline" should set the property value
|
||||
Fail e.style['text-decoration-line'] = "overline blink underline line-through" should set the property value
|
||||
Fail e.style['text-decoration-line'] = "overline blink line-through underline" should set the property value
|
||||
Fail e.style['text-decoration-line'] = "line-through underline overline blink" should set the property value
|
||||
Fail e.style['text-decoration-line'] = "line-through underline blink overline" should set the property value
|
||||
Fail e.style['text-decoration-line'] = "line-through overline underline blink" should set the property value
|
||||
Fail e.style['text-decoration-line'] = "line-through overline blink underline" should set the property value
|
||||
Fail e.style['text-decoration-line'] = "line-through blink underline overline" should set the property value
|
||||
Fail e.style['text-decoration-line'] = "line-through blink overline underline" should set the property value
|
||||
Fail e.style['text-decoration-line'] = "blink underline overline line-through" should set the property value
|
||||
Fail e.style['text-decoration-line'] = "blink underline line-through overline" should set the property value
|
||||
Fail e.style['text-decoration-line'] = "blink overline underline line-through" should set the property value
|
||||
Fail e.style['text-decoration-line'] = "blink overline line-through underline" should set the property value
|
||||
Fail e.style['text-decoration-line'] = "blink line-through underline overline" should set the property value
|
||||
Fail e.style['text-decoration-line'] = "blink line-through overline underline" should set the property value
|
||||
Pass e.style['text-decoration-line'] = "underline overline blink line-through" should set the property value
|
||||
Pass e.style['text-decoration-line'] = "underline line-through overline blink" should set the property value
|
||||
Pass e.style['text-decoration-line'] = "underline line-through blink overline" should set the property value
|
||||
Pass e.style['text-decoration-line'] = "underline blink overline line-through" should set the property value
|
||||
Pass e.style['text-decoration-line'] = "underline blink line-through overline" should set the property value
|
||||
Pass e.style['text-decoration-line'] = "overline underline line-through blink" should set the property value
|
||||
Pass e.style['text-decoration-line'] = "overline underline blink line-through" should set the property value
|
||||
Pass e.style['text-decoration-line'] = "overline line-through underline blink" should set the property value
|
||||
Pass e.style['text-decoration-line'] = "overline line-through blink underline" should set the property value
|
||||
Pass e.style['text-decoration-line'] = "overline blink underline line-through" should set the property value
|
||||
Pass e.style['text-decoration-line'] = "overline blink line-through underline" should set the property value
|
||||
Pass e.style['text-decoration-line'] = "line-through underline overline blink" should set the property value
|
||||
Pass e.style['text-decoration-line'] = "line-through underline blink overline" should set the property value
|
||||
Pass e.style['text-decoration-line'] = "line-through overline underline blink" should set the property value
|
||||
Pass e.style['text-decoration-line'] = "line-through overline blink underline" should set the property value
|
||||
Pass e.style['text-decoration-line'] = "line-through blink underline overline" should set the property value
|
||||
Pass e.style['text-decoration-line'] = "line-through blink overline underline" should set the property value
|
||||
Pass e.style['text-decoration-line'] = "blink underline overline line-through" should set the property value
|
||||
Pass e.style['text-decoration-line'] = "blink underline line-through overline" should set the property value
|
||||
Pass e.style['text-decoration-line'] = "blink overline underline line-through" should set the property value
|
||||
Pass e.style['text-decoration-line'] = "blink overline line-through underline" should set the property value
|
||||
Pass e.style['text-decoration-line'] = "blink line-through underline overline" should set the property value
|
||||
Pass e.style['text-decoration-line'] = "blink line-through overline underline" should set the property value
|
||||
Fail e.style['text-decoration-line'] = "spelling-error" should set the property value
|
||||
Fail e.style['text-decoration-line'] = "grammar-error" should set the property value
|
||||
Loading…
Reference in a new issue