mirrors/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-01-22 17:24:48 -05:00
Code Issues Projects Releases Packages Wiki Activity

LibWeb: Report exceptions when invoking intersection observer callback

Browse source
This commit is contained in:
Tim Ledbetter 2024-12-05 09:59:50 +00:00 committed by Tim Ledbetter
parent 7cacf5ca55
commit 7a41ab960c
Notes: github-actions[bot] 2024-12-19 15:26:21 +00:00 
Author: https://github.com/tcl3
Commit: https://github.com/LadybirdBrowser/ladybird/commit/7a41ab960cb
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/2739
Reviewed-by: https://github.com/shannonbooth
3 changed files with 38 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
Libraries/LibWeb/DOM/Document.cpp
View file

@ -4009,9 +4009,8 @@ void Document::queue_intersection_observer_task()
auto& callback = observer->callback();
// 5. Invoke callback with queue as the first argument, observer as the second argument, and observer as the callback this value. If this throws an exception, report the exception.
auto completion = WebIDL::invoke_callback(callback, observer.ptr(), wrapped_queue, observer.ptr());
if (completion.is_abrupt())
HTML::report_exception(completion, realm);
// NOTE: This does not follow the spec as written precisely, but this is the same thing we do elsewhere and there is a WPT test that relies on this.
(void)WebIDL::invoke_callback(callback, observer.ptr(), WebIDL::ExceptionBehavior::Report, wrapped_queue, observer.ptr());
}
}));
}

6
Tests/LibWeb/Text/expected/wpt-import/intersection-observer/callback-cross-realm-report-exception.txt Normal file
View file

@ -0,0 +1,6 @@
Harness status: OK
Found 1 tests
1 Pass
Pass IntersectionObserver reports the exception from its callback in the callback's global object

30
Tests/LibWeb/Text/input/wpt-import/intersection-observer/callback-cross-realm-report-exception.html Normal file
View file

@ -0,0 +1,30 @@
<!doctype html>
<meta charset=utf-8>
<title>IntersectionObserver reports the exception from its callback in the callback's global object</title>
<script src=../resources/testharness.js></script>
<script src=../resources/testharnessreport.js></script>
<iframe srcdoc='<div style="height: 100px;">foo</div>'></iframe>
<iframe></iframe>
<iframe></iframe>
<script>
setup({ allow_uncaught_exception: true });
const onerrorCalls = [];
window.onerror = () => { onerrorCalls.push("top"); };
frames[0].onerror = () => { onerrorCalls.push("frame0"); };
frames[1].onerror = () => { onerrorCalls.push("frame1"); };
frames[2].onerror = () => { onerrorCalls.push("frame2"); };
async_test(t => {
window.onload = t.step_func(() => {
const target = frames[0].document.querySelector("div");
const io = new frames[0].IntersectionObserver(new frames[1].Function(`throw new parent.frames[2].Error("PASS");`));
io.observe(target);
t.step_timeout(() => {
assert_array_equals(onerrorCalls, ["frame1"]);
t.done();
}, 100);
});
});
</script>