mirrors/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-01-22 09:12:13 -05:00
Code Issues Projects Releases Packages Wiki Activity

ClangPlugins: Remove confusing hasType check for lambda capture types

Browse source 
This check asserts that templated types will never escape. Which doesn't
hold up at all in practice.
This commit is contained in:
Andrew Kaster 2024-12-09 19:51:05 -07:00 committed by Andreas Kling
parent 2f38c83caf
commit 85b87508bf
Notes: github-actions[bot] 2024-12-10 06:13:49 +00:00 
Author: https://github.com/ADKaster
Commit: https://github.com/LadybirdBrowser/ladybird/commit/85b87508bf1
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/2860
1 changed files with 1 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
Meta/Lagom/ClangPlugins/LambdaCapturePluginAction.cpp
View file

@ -84,12 +84,7 @@ public:
unless(hasParent(
// <lambda struct>::operator()(...)
cxxOperatorCallExpr(has(declRefExpr(to(equalsBoundNode("lambda")))))))))),
parmVarDecl(
allOf(
// It's important that the parameter has a RecordType, as a templated type can never escape its function
hasType(cxxRecordDecl()),
hasAnnotation("serenity::escaping")))
.bind("lambda-param-ref")))),
parmVarDecl(hasAnnotation("serenity::escaping")).bind("lambda-param-ref")))),
this);
}