mirrors/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-01-22 09:12:13 -05:00
Code Issues Projects Releases Packages Wiki Activity

LibWeb: Implement the "fontName" editing command

Browse source
This commit is contained in:
Jelle Raaijmakers 2025-01-08 14:39:31 +01:00 committed by Andreas Kling
parent 1b02e0dea3
commit 9366a50dd3
Notes: github-actions[bot] 2025-01-10 22:37:01 +00:00 
Author: https://github.com/gmta
Commit: https://github.com/LadybirdBrowser/ladybird/commit/9366a50dd35
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/3216
4 changed files with 39 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
Libraries/LibWeb/Editing/Commands.cpp
View file

@ -492,6 +492,14 @@ bool command_delete_action(DOM::Document& document, String const&)
return true;
}
// https://w3c.github.io/editing/docs/execCommand/#the-fontname-command
bool command_font_name_action(DOM::Document& document, String const& value)
{
// Set the selection's value to value, then return true.
set_the_selections_value(document, CommandNames::fontName, value);
return true;
}
// https://w3c.github.io/editing/docs/execCommand/#the-forwarddelete-command
bool command_forward_delete_action(DOM::Document& document, String const&)
{
@ -1115,6 +1123,12 @@ static Array const commands {
.action = command_default_paragraph_separator_action,
.value = command_default_paragraph_separator_value,
},
// https://w3c.github.io/editing/docs/execCommand/#the-fontname-command
CommandDefinition {
.command = CommandNames::fontName,
.action = command_font_name_action,
.relevant_css_property = CSS::PropertyID::FontFamily,
},
// https://w3c.github.io/editing/docs/execCommand/#the-forwarddelete-command
CommandDefinition {
.command = CommandNames::forwardDelete,

1
Libraries/LibWeb/Editing/Commands.h
View file

@ -35,6 +35,7 @@ bool command_create_link_action(DOM::Document&, String const&);
bool command_default_paragraph_separator_action(DOM::Document&, String const&);
String command_default_paragraph_separator_value(DOM::Document const&);
bool command_delete_action(DOM::Document&, String const&);
bool command_font_name_action(DOM::Document&, String const&);
bool command_forward_delete_action(DOM::Document&, String const&);
bool command_insert_linebreak_action(DOM::Document&, String const&);
bool command_insert_paragraph_action(DOM::Document&, String const&);

2
Tests/LibWeb/Text/expected/Editing/execCommand-fontName.txt Normal file
View file

@ -0,0 +1,2 @@
foo<font face="monospace" style="font-family: monospace;">bar</font>
<font face="sans-serif" style="font-family: sans-serif;">foo</font><font face="sans-serif" style="font-family: sans-serif;"><font style="">bar</font></font>

22
Tests/LibWeb/Text/input/Editing/execCommand-fontName.html Normal file
View file

@ -0,0 +1,22 @@
<script src="../include.js"></script>
<div contenteditable="true">foobar</div>
<script>
test(() => {
const range = document.createRange();
getSelection().addRange(range);
const divElm = document.querySelector('div');
// Set fontName for 'bar'
range.setStart(divElm.childNodes[0], 3);
range.setEnd(divElm.childNodes[0], 6);
document.execCommand('fontName', false, 'monospace');
println(divElm.innerHTML);
// Set fontName for the entire editable div
range.setStart(divElm, 0);
range.setEnd(divElm, 2);
document.execCommand('fontName', false, 'sans-serif');
println(divElm.innerHTML);
});
</script>