mirrors/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-01-22 17:24:48 -05:00
Code Issues Projects Releases Packages Wiki Activity

LibWeb: Implement the HTMLInputElement.height attribute

Browse source 
This allows the height of an image button input to be set and queried.
This commit is contained in:
Tim Ledbetter 2024-11-29 17:56:24 +00:00 committed by Andreas Kling
parent 45a2823e08
commit b39fdcfec2
Notes: github-actions[bot] 2024-11-30 10:19:26 +00:00 
Author: https://github.com/tcl3
Commit: https://github.com/LadybirdBrowser/ladybird/commit/b39fdcfec23
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/2645
5 changed files with 60 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

35
Libraries/LibWeb/HTML/HTMLInputElement.cpp
View file

@ -1882,6 +1882,41 @@ WebIDL::ExceptionOr<void> HTMLInputElement::set_size(WebIDL::UnsignedLong value)
return set_attribute(HTML::AttributeNames::size, String::number(value));
}
// https://html.spec.whatwg.org/multipage/input.html#dom-input-height
WebIDL::UnsignedLong HTMLInputElement::height() const
{
const_cast<DOM::Document&>(document()).update_layout();
// When the input element's type attribute is not in the Image Button state, then no image is available.
if (type_state() != TypeAttributeState::ImageButton)
return 0;
// Return the rendered height of the image, in CSS pixels, if the image is being rendered.
if (auto* paintable_box = this->paintable_box())
return paintable_box->content_height().to_int();
// On setting [the width or height IDL attribute], they must act as if they reflected the respective content attributes of the same name.
if (auto height_string = get_attribute(HTML::AttributeNames::height); height_string.has_value()) {
if (auto height = parse_non_negative_integer(*height_string); height.has_value() && *height <= 2147483647)
return *height;
}
// ...or else the natural height and height of the image, in CSS pixels, if an image is available but not being rendered
if (auto bitmap = current_image_bitmap())
return bitmap->height();
// ...or else 0, if the image is not available or does not have intrinsic dimensions.
return 0;
}
WebIDL::ExceptionOr<void> HTMLInputElement::set_height(WebIDL::UnsignedLong value)
{
if (value > 2147483647)
value = 0;
return set_attribute(HTML::AttributeNames::height, String::number(value));
}
// https://html.spec.whatwg.org/multipage/input.html#dom-input-width
WebIDL::UnsignedLong HTMLInputElement::width() const
{

3
Libraries/LibWeb/HTML/HTMLInputElement.h
View file

@ -128,6 +128,9 @@ public:
WebIDL::UnsignedLong size() const;
WebIDL::ExceptionOr<void> set_size(WebIDL::UnsignedLong value);
WebIDL::UnsignedLong height() const;
WebIDL::ExceptionOr<void> set_height(WebIDL::UnsignedLong value);
WebIDL::UnsignedLong width() const;
WebIDL::ExceptionOr<void> set_width(WebIDL::UnsignedLong value);

2
Libraries/LibWeb/HTML/HTMLInputElement.idl
View file

@ -22,7 +22,7 @@ interface HTMLInputElement : HTMLElement {
[CEReactions, Reflect=formmethod, Enumerated=FormMethodAttribute] attribute DOMString formMethod;
[CEReactions, Reflect=formnovalidate] attribute boolean formNoValidate;
[CEReactions, Reflect=formtarget] attribute DOMString formTarget;
[FIXME, CEReactions] attribute unsigned long height;
[CEReactions] attribute unsigned long height;
attribute boolean indeterminate;
[FIXME] readonly attribute HTMLDataListElement? list;
[CEReactions, Reflect] attribute DOMString max;

20
Tests/LibWeb/Text/expected/HTML/unsigned-long-reflection.txt
View file

@ -37,6 +37,26 @@ input.getAttribute("size") after input.setAttribute("size", "4294967295"): 42949
input.size after input.setAttribute("size", "4294967295"): 20
input.getAttribute("size") after input.size = 4294967295: 20
input.size after input.size = 4294967295: 20
input.getAttribute("height") after input.setAttribute("height", "0"): 0
input.height after input.setAttribute("height", "0"): 0
input.getAttribute("height") after input.height = 0: 0
input.height after input.height = 0: 0
input.getAttribute("height") after input.setAttribute("height", "1"): 1
input.height after input.setAttribute("height", "1"): 1
input.getAttribute("height") after input.height = 1: 1
input.height after input.height = 1: 0
input.getAttribute("height") after input.setAttribute("height", "2147483647"): 2147483647
input.height after input.setAttribute("height", "2147483647"): 2147483647
input.getAttribute("height") after input.height = 2147483647: 2147483647
input.height after input.height = 2147483647: 0
input.getAttribute("height") after input.setAttribute("height", "2147483648"): 2147483648
input.height after input.setAttribute("height", "2147483648"): 0
input.getAttribute("height") after input.height = 2147483648: 0
input.height after input.height = 2147483648: 0
input.getAttribute("height") after input.setAttribute("height", "4294967295"): 4294967295
input.height after input.setAttribute("height", "4294967295"): 0
input.getAttribute("height") after input.height = 4294967295: 0
input.height after input.height = 4294967295: 0
input.getAttribute("width") after input.setAttribute("width", "0"): 0
input.width after input.setAttribute("width", "0"): 0
input.getAttribute("width") after input.width = 0: 0

1
Tests/LibWeb/Text/input/HTML/unsigned-long-reflection.html
View file

@ -44,6 +44,7 @@
testProperty("img", "hspace", (img) => img.hspace, (img, value) => img.hspace = value);
testProperty("input", "size", (input) => input.size, (input, value) => input.size = value);
testProperty(imageButtonInputFactory, "height", (input) => input.height, (input, value) => input.height = value);
testProperty(imageButtonInputFactory, "width", (input) => input.width, (input, value) => input.width = value);
testProperty("marquee", "scrollAmount", (marquee) => marquee.scrollAmount, (marquee, value) => marquee.scrollAmount = value);
testProperty("marquee", "scrollDelay", (marquee) => marquee.scrollDelay, (marquee, value) => marquee.scrollDelay = value);