mirrors/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-01-22 09:12:13 -05:00
Code Issues Projects Releases Packages Wiki Activity

AK: Fix InsertionSort to respect specified bounds

Browse source 
Previously, it ignored 'start', sorting from the array's
beginning. This caused unintended changes and slower
performance. Fix ensures sorting stays within 'start'
and 'end' indices only.
This commit is contained in:
Pavel Shliak 2024-12-04 23:59:19 +04:00 committed by Tim Ledbetter
parent fa28337817
commit c16c20b836
Notes: github-actions[bot] 2024-12-06 06:45:20 +00:00 
Author: https://github.com/shlyakpavel
Commit: https://github.com/LadybirdBrowser/ladybird/commit/c16c20b8365
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/2766
Reviewed-by: https://github.com/gmta ✅
2 changed files with 24 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
AK/InsertionSort.h
View file

@ -17,7 +17,7 @@ void insertion_sort(Collection& col, ssize_t start, ssize_t end, Comparator comp
requires(Indexable<Collection, T>)
{
for (ssize_t i = start + 1; i <= end; ++i) {
for (ssize_t j = i; j > 0 && comparator(col[j], col[j - 1]); --j)
for (ssize_t j = i; j > start && comparator(col[j], col[j - 1]); --j)
swap(col[j], col[j - 1]);
}
}

23
Tests/AK/TestInsertionSort.cpp
View file

@ -55,3 +55,26 @@ TEST_CASE(sorts_decending)
}
}
}
TEST_CASE(sorts_subrange_without_affecting_outside_elements)
{
Vector<int> ints = { 10, 9, 8, 7, 6, 5, 4, 3, 2, 1 };
Vector<int> const original_ints = ints;
ssize_t const start = 3;
ssize_t const end = 6;
insertion_sort(ints, start, end, [](auto& a, auto& b) { return a < b; });
for (ssize_t i = start; i < end; ++i) {
EXPECT(ints[i] <= ints[i + 1]);
}
for (ssize_t i = 0; i < start; ++i) {
EXPECT_EQ(ints[i], original_ints[i]);
}
for (ssize_t i = end + 1; i < static_cast<ssize_t>(ints.size()); ++i) {
EXPECT_EQ(ints[i], original_ints[i]);
}
}