mirrors/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-01-22 09:12:13 -05:00
Code Issues Projects Releases Packages Wiki Activity

LibWeb: Require existing Selection for .execCommand("selectAll")

Browse source 
Disable the command if no selection is available. This is a spec bug:

https://github.com/w3c/editing/issues/475

Fixes #3325
This commit is contained in:
Jelle Raaijmakers 2025-01-20 23:56:55 +01:00 committed by Tim Ledbetter
parent 96e074b38f
commit d967f56936
Notes: github-actions[bot] 2025-01-21 02:28:49 +00:00 
Author: https://github.com/gmta
Commit: https://github.com/LadybirdBrowser/ladybird/commit/d967f56936e
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/3328
Reviewed-by: https://github.com/tcl3 ✅
3 changed files with 21 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
Libraries/LibWeb/Editing/ExecCommand.cpp
View file

@ -112,17 +112,17 @@ bool Document::query_command_enabled(FlyString const& command)
if (command.is_one_of(
Editing::CommandNames::defaultParagraphSeparator,
Editing::CommandNames::redo,
Editing::CommandNames::selectAll,
Editing::CommandNames::styleWithCSS,
Editing::CommandNames::undo,
Editing::CommandNames::useCSS))
return true;
// AD-HOC: selectAll requires a selection object to exist.
if (command == Editing::CommandNames::selectAll)
return get_selection();
// The other commands defined here are enabled if the active range is not null,
auto selection = get_selection();
if (!selection)
return false;
auto active_range = selection->range();
auto active_range = Editing::active_range(*this);
if (!active_range)
return false;

4
Tests/LibWeb/Text/expected/Editing/execCommand-selectAll.txt
View file

@ -1,3 +1,7 @@
No range.
DIV 0 - DIV 0
BODY 0 - BODY 5
true
false
false
Did not crash!

12
Tests/LibWeb/Text/input/Editing/execCommand-selectAll.html
View file

@ -33,5 +33,17 @@
// Perform selectAll
document.execCommand('selectAll');
reportSelection();
// Report whether command is enabled and make sure it does not crash
const documents = [
document,
new Document(),
document.implementation.createHTMLDocument(),
];
for (const doc of documents) {
println(doc.queryCommandEnabled('selectAll'));
doc.execCommand('selectAll');
}
println('Did not crash!');
});
</script>