mirrors/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-01-22 09:12:13 -05:00
Code Issues Projects Releases Packages Wiki Activity

LibWeb/WebGL2: Implement getSyncParameter

Browse source
This commit is contained in:
Luke Wilde 2024-12-31 12:08:24 +00:00 committed by Alexander Kalenik
parent 6bf6cd3f19
commit e5d59a2d42
Notes: github-actions[bot] 2025-01-08 14:56:48 +00:00 
Author: https://github.com/Lubrsi
Commit: https://github.com/LadybirdBrowser/ladybird/commit/e5d59a2d420
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/2943
Reviewed-by: https://github.com/kalenikaliaksandr
2 changed files with 17 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
Libraries/LibWeb/WebGL/WebGL2RenderingContextBase.idl
View file

@ -401,7 +401,7 @@ interface mixin WebGL2RenderingContextBase {
undefined deleteSync(WebGLSync? sync);
GLenum clientWaitSync(WebGLSync sync, GLbitfield flags, GLuint64 timeout);
[FIXME] undefined waitSync(WebGLSync sync, GLbitfield flags, GLint64 timeout);
[FIXME] any getSyncParameter(WebGLSync sync, GLenum pname);
any getSyncParameter(WebGLSync sync, GLenum pname);
// Transform Feedback
[FIXME] WebGLTransformFeedback createTransformFeedback();

16
Meta/Lagom/Tools/CodeGenerators/LibWeb/GenerateWebGLRenderingContext.cpp
View file

@ -951,6 +951,22 @@ public:
continue;
}
if (function.name == "getSyncParameter"sv) {
// FIXME: In order to ensure consistent behavior across platforms, sync objects may only transition to the
// signaled state when the user agent's event loop is not executing a task. In other words:
// - A sync object must not become signaled until control has returned to the user agent's main
// loop.
// - Repeatedly fetching a sync object's SYNC_STATUS parameter in a loop, without returning
// control to the user agent, must always return the same value.
// FIXME: Remove the GLsync cast once sync_handle actually returns the proper GLsync type.
function_impl_generator.append(R"~~~(
GLint result = 0;
glGetSynciv((GLsync)(sync ? sync->sync_handle() : nullptr), pname, 1, nullptr, &result);
return JS::Value(result);
)~~~");
continue;
}
if (function.name == "bufferData"sv && function.overload_index == 0) {
function_impl_generator.append(R"~~~(
glBufferData(target, size, 0, usage);