mirrors/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-01-22 17:24:48 -05:00
Code Issues Projects Releases Packages Wiki Activity

LibWeb/HTML: Use finalize to clean up MessagePort instances

Browse source
This commit is contained in:
Shannon Booth 2025-01-01 01:20:37 +13:00 committed by Andreas Kling
parent 0b2c80e503
commit e767029e24
Notes: github-actions[bot] 2025-01-02 10:39:57 +00:00 
Author: https://github.com/shannonbooth
Commit: https://github.com/LadybirdBrowser/ladybird/commit/e767029e243
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/3070
Reviewed-by: https://github.com/awesomekling
Reviewed-by: https://github.com/konradekk
2 changed files with 9 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
Libraries/LibWeb/HTML/MessagePort.cpp
View file

@ -47,11 +47,7 @@ MessagePort::MessagePort(JS::Realm& realm)
all_message_ports().set(this);
}
MessagePort::~MessagePort()
{
all_message_ports().remove(this);
disentangle();
}
MessagePort::~MessagePort() = default;
void MessagePort::for_each_message_port(Function<void(MessagePort&)> callback)
{
@ -65,6 +61,13 @@ void MessagePort::initialize(JS::Realm& realm)
WEB_SET_PROTOTYPE_FOR_INTERFACE(MessagePort);
}
void MessagePort::finalize()
{
Base::finalize();
all_message_ports().remove(this);
disentangle();
}
void MessagePort::visit_edges(Cell::Visitor& visitor)
{
Base::visit_edges(visitor);

1
Libraries/LibWeb/HTML/MessagePort.h
View file

@ -68,6 +68,7 @@ private:
explicit MessagePort(JS::Realm&);
virtual void initialize(JS::Realm&) override;
virtual void finalize() override;
virtual void visit_edges(Cell::Visitor&) override;
bool is_entangled() const;