mirrors/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-01-22 09:12:13 -05:00
Code Issues Projects Releases Packages Wiki Activity

LibWeb: Mark a few calls to set_attribute as infallible

Browse source 
These cannot possibly throw an exception because the attribute names are
already known to be valid.
This commit is contained in:
Timothy Flynn 2025-01-14 19:42:12 -05:00 committed by Jelle Raaijmakers
parent b43bb2429a
commit e95096d2a9
Notes: github-actions[bot] 2025-01-15 07:47:49 +00:00 
Author: https://github.com/trflynn89
Commit: https://github.com/LadybirdBrowser/ladybird/commit/e95096d2a99
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/3257
Reviewed-by: https://github.com/gmta ✅
3 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
Libraries/LibWeb/HTML/HTMLLIElement.h
View file

@ -38,7 +38,7 @@ public:
WebIDL::Long value();
void set_value(WebIDL::Long value)
{
set_attribute(AttributeNames::value, String::number(value)).release_value_but_fixme_should_propagate_errors();
MUST(set_attribute(AttributeNames::value, String::number(value)));
}
private:

2
Libraries/LibWeb/HTML/HTMLOListElement.h
View file

@ -25,7 +25,7 @@ public:
WebIDL::Long start();
void set_start(WebIDL::Long start)
{
set_attribute(AttributeNames::start, String::number(start)).release_value_but_fixme_should_propagate_errors();
MUST(set_attribute(AttributeNames::start, String::number(start)));
}
private:

2
Libraries/LibWeb/HTML/HTMLSummaryElement.cpp
View file

@ -37,7 +37,7 @@ void HTMLSummaryElement::activation_behavior(DOM::Event const&)
if (parent->has_attribute(HTML::AttributeNames::open))
parent->remove_attribute(HTML::AttributeNames::open);
else
parent->set_attribute(HTML::AttributeNames::open, String {}).release_value_but_fixme_should_propagate_errors();
MUST(parent->set_attribute(HTML::AttributeNames::open, String {}));
}
// https://html.spec.whatwg.org/multipage/interactive-elements.html#summary-for-its-parent-details