Andreas Kling
56c3748dcc
LibWeb: Rename PageView => InProcessWebView
2020-08-17 18:05:35 +02:00
Andreas Kling
ba856c7ebe
LibDebug: Don't include <Libraries/...>
2020-08-17 18:05:35 +02:00
Andreas Kling
d62a59d7b8
LibCrypto: Don't include <Libraries/...>
2020-08-17 18:05:35 +02:00
Andreas Kling
c0462c65cf
HackStudio: Move everything into the HackStudio namespace
2020-08-17 18:05:35 +02:00
Andreas Kling
ce48de9845
LibGUI: Add WidgetClassRegistration to Forward.h
2020-08-17 18:05:35 +02:00
Luke
c434a91c91
FileManager: Apply wallpaper on startup
...
I noticed that nothing actually applies the wallpaper on startup.
I wasn't sure where to put the responsibility, so I gave it to
the desktop mode file manager.
Also adds a save_config option to set_wallpaper so it doesn't
needlessly save the config.
2020-08-17 17:47:14 +02:00
AnotherTest
14a54a72fa
Shell: Ensure that the cursor starts on a new line
...
And print an indicator when it doesn't, a la zsh.
2020-08-17 17:44:02 +02:00
AnotherTest
c96b9fdb0a
LibLine: Add a getter for num_lines/num_cols
2020-08-17 17:44:02 +02:00
Tibor Nagy
fbc3b8e3c8
Solitaire: Rename "Restart game" menu item to "New game"
...
Also adding a shortcut (F2) to make it consistent with other games.
2020-08-17 17:39:56 +02:00
Tibor Nagy
e3d1ea34ff
Games: Add missing separators to the application menus
2020-08-17 17:39:56 +02:00
Andreas Kling
a27d782dd6
FileManager: Don't close() twice when copying a file
2020-08-17 13:12:46 +02:00
Andreas Kling
0fecdb7904
disasm: Use make<X86::ELFSymbolProvider> instead of naked new
2020-08-17 13:12:46 +02:00
AnicJov
ac4897d613
LibWeb: Change cursor to IBeam when hovering text
...
This is what most browsers do, hopefully it isn't too silly :^)
2020-08-17 13:07:18 +02:00
Abu Sakib
1ec0f54de1
Chess: Add Help menuitem
2020-08-17 12:12:19 +02:00
Andreas Kling
d5d54da0ea
Kernel: Don't use copy_from_user() for kernelspace read in perf events
...
Fixes #3182 .
2020-08-17 09:57:18 +02:00
Nico Weber
22f701d657
malloc: Keep some stats and dump them at process exit if LIBC_DUMP_MALLOC_STATS is set
...
Very bare-bones and barely useful. Can go away once the perf_event-based
malloc tracking is further along.
2020-08-17 09:43:23 +02:00
Brian Gianforcaro
c44d2515b4
Kernel: Emit ProcFS pledge/veil properties as "N/A" for kernel processes
...
Pledges and Veil state don't really make sense for kernel mode
processes, as they can do what ever they want since they are in
kernel mode. Make this clear in the system monitor UI by marking
these entries as null.
2020-08-17 09:42:07 +02:00
Brian Gianforcaro
6fa76ed2e3
LibCore: Fix unitialized struct member in to_address_in, found by Coverity
2020-08-17 09:17:57 +02:00
Brian Gianforcaro
73ab030f88
FileManager: Fix descriptor leak in copy_file, found by Coverity
2020-08-17 09:17:57 +02:00
Brian Gianforcaro
e43d5d5eaa
FileManger: Fix file descriptor leak in copy_file_or_directory, found by Coverity
2020-08-17 09:17:57 +02:00
Brian Gianforcaro
bcbac83a8b
Userland: Explicitly ignore number of types read, found by Coverity
2020-08-17 09:17:57 +02:00
Brian Gianforcaro
9ffbe03bdb
LibC: Missing varargs cleanup in ioctl
2020-08-17 09:17:57 +02:00
Brian Gianforcaro
dc278c3aa1
LibC: Missing varargs cleanup in fcntl
2020-08-17 09:17:57 +02:00
Brian Gianforcaro
4ca493a86a
UserspaceEmulator: Extra format arguments in MallocTracker, found by Coverity
2020-08-17 09:17:57 +02:00
Brian Gianforcaro
5a3cc2da8b
UserspaceEmulator: Identical code on both branches, unify return in virt$ioctl
2020-08-17 09:17:57 +02:00
Brian Gianforcaro
7688539402
UserspaceEmulator: Fix conditionally uninitialized locals in virt$select
2020-08-17 09:17:57 +02:00
Brian Gianforcaro
f7b1591a5c
SystemMonitor: Uninitialized struct member in ProcessModel, found by Coverity
...
This is really a nop, as the cpu_percent is computed later. Zero the
value just to keep things sane.
2020-08-17 09:17:57 +02:00
Brian Gianforcaro
c1fd41c38c
LibLine: Uninitialized members in Editor, found by Coverity
2020-08-17 09:17:57 +02:00
Brian Gianforcaro
3ee0917dcb
SoundPlayer: Uninitialized variable in SoundPlayerWidget, found by Coverity
2020-08-17 09:17:57 +02:00
Brian Gianforcaro
0ca00639a9
LibThread: Uninitialized member variable in Thread, found by Coverity
2020-08-17 09:17:57 +02:00
Brian Gianforcaro
e160181a73
Piano: Uninitialized member variables in RollWidet, found by Coverity
...
This seem like they wouldn't cause any problems in reality,
but it's nice to fix them to avoid any future misuse.
2020-08-17 09:17:57 +02:00
Brian Gianforcaro
eed9f2bac3
Chess: Uninitialized member in PromotionalDialog, found by Coverity
2020-08-17 09:17:57 +02:00
Brian Gianforcaro
832b3256d3
LibWeb: Remove unused member in LayoutNodeWithStyle, found by Coverity
2020-08-17 09:17:57 +02:00
Brian Gianforcaro
82b3dab1b5
LibELF: Fix uninitialized member variable in DynamicLoader, found by Coverity
2020-08-17 09:17:57 +02:00
Brian Gianforcaro
82dbf76dee
LibCompress: Fix uninitialized member variable in Zlib, found by Coverity
2020-08-17 09:17:57 +02:00
Brian Gianforcaro
ff0c7da75d
AK: Add SFINAE fallback for AK C++ concepts use, for Coverity compiler
...
The Coverity compiler doesn't support C++2a yet, and thus doesn't
even recognize concept keywords. To allow serenity to be built and
analyzed on such compilers, add a fallback underdef to perform
the same template restriction based on AK::EnableIf<..> meta
programming.
Note: Coverity does seem to (annoyingly) define __cpp_concepts, even
though it doesn't support them, so we need to further check for
__COVERITY__ explicitly.
2020-08-17 09:17:57 +02:00
Nico Weber
2030a49a1e
malloc: Remove unused Bitmap.h include
2020-08-17 09:10:06 +02:00
Nico Weber
de4a9c61d7
malloc: Fix build with RECYCLE_BIG_ALLOCATIONS not defined
2020-08-17 09:10:06 +02:00
Nico Weber
344090a5b0
malloc: Add comments spelling out the MAGIC_HEADERS in ascii
2020-08-17 09:10:06 +02:00
Nico Weber
96ff0971ea
Kernel: Remove a comment that has been stale since 7a64f55c0f
2020-08-17 09:10:06 +02:00
Ben Wiederhake
b0aa8115c2
Userland: Provide a misbehaving application
...
This will be a test case for #2977 .
2020-08-17 00:01:13 +02:00
Andreas Kling
1e4c43bbd0
Kernel: Remove strncpy() and strrchr()
...
These are not called anywhere in the kernel anyway.
2020-08-17 00:00:46 +02:00
Sarah
ee912e023c
LibGfx: Move original StylePainter code to ClassicStylePainter
...
StylePainter should continue to work the same as before.
2020-08-17 00:00:34 +02:00
Sarah
d0900228d0
LibGfx: Add abstract StylePainter class
...
StylePainter's behavior is now handled by a static instance
of BaseStylePainter. The original static behavior of StylePainter
is left as-is for API compatibility.
2020-08-17 00:00:34 +02:00
asynts
868bd2e43d
LibCrypto: Call bytes() explicitly instead of implicitly.
...
This was a careless mistake.
https://github.com/SerenityOS/serenity/pull/3166#discussion_r471131732
2020-08-17 00:00:14 +02:00
asynts
aef6f00195
AK: Always call memmove in Span instead of memcpy.
...
https://github.com/SerenityOS/serenity/pull/3166#discussion_r471031704
2020-08-17 00:00:14 +02:00
Nico Weber
5de131667a
LibHTTP: Remove unused private field m_queued_finish in HttpsJob ( #3181 )
2020-08-16 23:58:50 +02:00
Andreas Kling
154a184c1b
Browser: Add a debug menu action for triggering a JS garbage collection
...
Triggering a GC this way will print a report afterwards so you can see
how much memory is currently used by the JS heap. :^)
2020-08-16 20:35:03 +02:00
Andreas Kling
bbd3192535
LibJS: Add API for doing GC with a little debug log report at end
...
You can now pass print_report=true to Heap::collect_garbage() and it
will print out a little summary of the time spent, and counts of
live vs freed cells and blocks.
2020-08-16 20:33:56 +02:00
Andreas Kling
6444f49d22
LibJS: Make StringOrSymbol not leak strings
...
Ideally this thing would not allocate strings at all, but I'll leave
that as a separate exercise.
2020-08-16 20:31:05 +02:00