mirror of
https://github.com/LadybirdBrowser/ladybird.git
synced 2025-01-24 10:12:25 -05:00
0ae2cef8b4
This was a footgun waiting to happen. The StringView encoder is only used internally within IPC::Encoder to encode DeprecatedString. It does not encode its null state nor its length. If someone were to innocently use the StringView encoder as it is, and then decode a DeprecatedString on the remote end, the decoding would be corrupt. This changes the StringView encoder to do the work the DeprecatedString encoder is currently doing, and the latter now just forwards to it.
142 lines
3.3 KiB
C++
142 lines
3.3 KiB
C++
/*
|
|
* Copyright (c) 2020, Andreas Kling <kling@serenityos.org>
|
|
* Copyright (c) 2021, kleines Filmröllchen <filmroellchen@serenityos.org>
|
|
*
|
|
* SPDX-License-Identifier: BSD-2-Clause
|
|
*/
|
|
|
|
#include <AK/BitCast.h>
|
|
#include <AK/ByteBuffer.h>
|
|
#include <AK/DeprecatedString.h>
|
|
#include <AK/JsonObject.h>
|
|
#include <AK/JsonValue.h>
|
|
#include <AK/NumericLimits.h>
|
|
#include <AK/URL.h>
|
|
#include <LibCore/AnonymousBuffer.h>
|
|
#include <LibCore/DateTime.h>
|
|
#include <LibCore/Proxy.h>
|
|
#include <LibCore/System.h>
|
|
#include <LibIPC/Dictionary.h>
|
|
#include <LibIPC/Encoder.h>
|
|
#include <LibIPC/File.h>
|
|
|
|
namespace IPC {
|
|
|
|
ErrorOr<void> Encoder::encode_size(size_t size)
|
|
{
|
|
if (static_cast<u64>(size) > static_cast<u64>(NumericLimits<u32>::max()))
|
|
return Error::from_string_literal("Container exceeds the maximum allowed size");
|
|
return encode(static_cast<u32>(size));
|
|
}
|
|
|
|
template<>
|
|
ErrorOr<void> encode(Encoder& encoder, float const& value)
|
|
{
|
|
return encoder.encode(bit_cast<u32>(value));
|
|
}
|
|
|
|
template<>
|
|
ErrorOr<void> encode(Encoder& encoder, double const& value)
|
|
{
|
|
return encoder.encode(bit_cast<u64>(value));
|
|
}
|
|
|
|
template<>
|
|
ErrorOr<void> encode(Encoder& encoder, StringView const& value)
|
|
{
|
|
// NOTE: Do not change this encoding without also updating LibC/netdb.cpp.
|
|
if (value.is_null())
|
|
return encoder.encode(NumericLimits<u32>::max());
|
|
|
|
TRY(encoder.encode_size(value.length()));
|
|
TRY(encoder.append(reinterpret_cast<u8 const*>(value.characters_without_null_termination()), value.length()));
|
|
return {};
|
|
}
|
|
|
|
template<>
|
|
ErrorOr<void> encode(Encoder& encoder, DeprecatedString const& value)
|
|
{
|
|
return encoder.encode(value.view());
|
|
}
|
|
|
|
template<>
|
|
ErrorOr<void> encode(Encoder& encoder, ByteBuffer const& value)
|
|
{
|
|
TRY(encoder.encode_size(value.size()));
|
|
TRY(encoder.append(value.data(), value.size()));
|
|
return {};
|
|
}
|
|
|
|
template<>
|
|
ErrorOr<void> encode(Encoder& encoder, JsonValue const& value)
|
|
{
|
|
return encoder.encode(value.serialized<StringBuilder>());
|
|
}
|
|
|
|
template<>
|
|
ErrorOr<void> encode(Encoder& encoder, URL const& value)
|
|
{
|
|
return encoder.encode(value.to_deprecated_string());
|
|
}
|
|
|
|
template<>
|
|
ErrorOr<void> encode(Encoder& encoder, Dictionary const& dictionary)
|
|
{
|
|
TRY(encoder.encode_size(dictionary.size()));
|
|
|
|
TRY(dictionary.try_for_each_entry([&](auto const& key, auto const& value) -> ErrorOr<void> {
|
|
TRY(encoder.encode(key));
|
|
TRY(encoder.encode(value));
|
|
return {};
|
|
}));
|
|
|
|
return {};
|
|
}
|
|
|
|
template<>
|
|
ErrorOr<void> encode(Encoder& encoder, File const& file)
|
|
{
|
|
int fd = file.fd();
|
|
|
|
if (fd != -1)
|
|
fd = TRY(Core::System::dup(fd));
|
|
|
|
TRY(encoder.append_file_descriptor(fd));
|
|
return {};
|
|
}
|
|
|
|
template<>
|
|
ErrorOr<void> encode(Encoder&, Empty const&)
|
|
{
|
|
return {};
|
|
}
|
|
|
|
template<>
|
|
ErrorOr<void> encode(Encoder& encoder, Core::AnonymousBuffer const& buffer)
|
|
{
|
|
TRY(encoder.encode(buffer.is_valid()));
|
|
|
|
if (buffer.is_valid()) {
|
|
TRY(encoder.encode_size(buffer.size()));
|
|
TRY(encoder.encode(IPC::File { buffer.fd() }));
|
|
}
|
|
|
|
return {};
|
|
}
|
|
|
|
template<>
|
|
ErrorOr<void> encode(Encoder& encoder, Core::DateTime const& datetime)
|
|
{
|
|
return encoder.encode(static_cast<i64>(datetime.timestamp()));
|
|
}
|
|
|
|
template<>
|
|
ErrorOr<void> encode(Encoder& encoder, Core::ProxyData const& proxy)
|
|
{
|
|
TRY(encoder.encode(proxy.type));
|
|
TRY(encoder.encode(proxy.host_ipv4));
|
|
TRY(encoder.encode(proxy.port));
|
|
return {};
|
|
}
|
|
|
|
}
|