ladybird/Libraries/LibGUI
Zac 6a569bbdd7 TextEditor: Change cursor behaviour when clicking empty space
When clicking empty space (beneath any used lines) in the TextEditor,
the cursor would jump to the start of the last line, rather than the
correct column, or the end of the line where appropriate. This was
because in the for_each_visual_line callback would return
IterationDecision::Continue if the clicked point wasn't in the line's
rect. Thus the callback would continue on each iteration and at the
end, would set the cursor to the default column of 0. To fix this I
added a bool to the callback's signature which tells the callback if
the for_each_visual_line method is on the last visual line. The
callback now does not return IterationDecision:Continue if
for_each_visual_line method is on the last line and the correct column
is then calculated with the line passed.
2020-11-19 21:59:13 +01:00
..
AboutDialog.cpp LibGUI: Tweak "OK" button height in GUI::AboutDialog 2020-10-26 21:01:45 +01:00
AboutDialog.h
AbstractButton.cpp LibGUI: Fix null parent deref in AbstractButton::set_checked() 2020-10-30 17:03:29 +01:00
AbstractButton.h LibGUI: Add Widget focus policies 2020-10-30 17:03:28 +01:00
AbstractTableView.cpp LibGUI: Remove AbstractTableView::doubleclick_event() 2020-11-19 21:57:05 +01:00
AbstractTableView.h LibGUI: Remove AbstractTableView::doubleclick_event() 2020-11-19 21:57:05 +01:00
AbstractView.cpp LibGUI: Prevent multiple drag initiations while drag messages are passed 2020-11-08 21:46:13 +01:00
AbstractView.h LibGUI: Prevent multiple drag initiations while drag messages are passed 2020-11-08 21:46:13 +01:00
Action.cpp Base: Move 16x16 common icons to /res/icons/16x16/ 2020-08-27 15:38:02 +02:00
Action.h LibGUI: Add a save_as common action 2020-08-25 09:46:28 +02:00
ActionGroup.cpp
ActionGroup.h Meta+LibC through LibHTTP: Make clang-format-10 clean 2020-09-25 21:18:17 +02:00
Application.cpp AK: Make RefPtr, NonnullRefPtr, WeakPtr thread safe 2020-11-10 19:11:52 +01:00
Application.h LibGUI: Update active tooltip when source widget changes the label 2020-08-15 13:45:08 +02:00
BoxLayout.cpp LibCore: Make Core::Object properties more dynamic 2020-09-15 21:46:26 +02:00
BoxLayout.h Meta+LibC through LibHTTP: Make clang-format-10 clean 2020-09-25 21:18:17 +02:00
Button.cpp AK: Make RefPtr, NonnullRefPtr, WeakPtr thread safe 2020-11-10 19:11:52 +01:00
Button.h LibGUI: Add Widget focus policies 2020-10-30 17:03:28 +01:00
Calendar.cpp LibGUI: Remove spacing between day labels in Calendar 2020-08-23 11:22:21 +02:00
Calendar.h LibGUI+Calendar: Make Calendar a common widget in LibGUI 2020-08-22 11:54:30 +02:00
CheckBox.cpp LibGUI+LibGfx: Improve focus rect appearance 2020-10-26 21:01:45 +01:00
CheckBox.h
Clipboard.cpp AK: Add trivial structure validation to SharedBuffer 2020-10-02 15:38:07 +02:00
Clipboard.h AK: Resolve format related circular dependencies properly. 2020-09-23 21:45:28 +02:00
CMakeLists.txt LibGfx: Move FontDatabase from LibGUI to LibGfx 2020-10-31 13:56:21 +01:00
ColorInput.cpp LibGUI: Use widget override cursors in ColorInput 2020-09-11 14:51:02 +02:00
ColorInput.h
ColorPicker.cpp Everywhere: Fix typos 2020-10-02 16:03:17 +02:00
ColorPicker.h LibGUI: Update color widgets when has_alpha is toggled in ColorPicker 2020-09-26 19:55:54 +02:00
ColumnsView.cpp LibGUI: Paint a focus rect around the cursor index in ColumnsView 2020-10-27 16:20:20 +01:00
ColumnsView.h LibGUI: Move keyboard item activation up to AbstractView 2020-09-24 21:35:47 +02:00
ComboBox.cpp LibGUI: Add Widget focus policies 2020-10-30 17:03:28 +01:00
ComboBox.h LibGUI: Add ComboBox::selected_index() 2020-08-21 21:16:13 +02:00
Command.cpp
Command.h HackStudio: Add C++ Language Server 2020-09-30 21:46:59 +02:00
ControlBoxButton.cpp
ControlBoxButton.h
CppSyntaxHighlighter.cpp LibCpp: Add library for working with c++ code 2020-09-30 21:46:59 +02:00
CppSyntaxHighlighter.h Meta+LibC through LibHTTP: Make clang-format-10 clean 2020-09-25 21:18:17 +02:00
Desktop.cpp FileManager: Apply wallpaper on startup 2020-08-17 17:47:14 +02:00
Desktop.h FileManager: Apply wallpaper on startup 2020-08-17 17:47:14 +02:00
Dialog.cpp LibGUI: Don't center dialog within parent if window is not visible 2020-08-16 16:37:39 +02:00
Dialog.h
DisplayLink.cpp
DisplayLink.h
DragOperation.cpp LibGUI+WindowServer: Make DragOperation hold a MimeData instance 2020-11-08 21:46:13 +01:00
DragOperation.h LibGUI+WindowServer: Make DragOperation hold a MimeData instance 2020-11-08 21:46:13 +01:00
EmojiInputDialog.cpp
EmojiInputDialog.h
Event.cpp
Event.h LibGUI: Make some GUI event getters return const references 2020-09-13 21:41:45 +02:00
FileIconProvider.cpp LibGUI/FileIconProvider: Add config file and use patterns 2020-11-15 16:49:40 +01:00
FileIconProvider.h LibGUI: Move file icon lookup into a separate FileIconProvider 2020-08-12 20:41:13 +02:00
FilePicker.cpp LibGUI: Make the Cancel/Okay buttons in GUI::FilePicker a little taller 2020-10-25 15:36:09 +01:00
FilePicker.h LibGUI: Rename ModelClient::on_model_update() => model_did_update() 2020-08-13 20:18:11 +02:00
FileSystemModel.cpp LibGfx: Make Bitmap path handling case insensitive 2020-11-14 10:11:26 +01:00
FileSystemModel.h LibGUI: Implement searching/jumping as you type in views 2020-10-22 15:23:45 +02:00
FilteringProxyModel.cpp LibGUI: Implement searching/jumping as you type in views 2020-10-22 15:23:45 +02:00
FilteringProxyModel.h LibGUI: Implement searching/jumping as you type in views 2020-10-22 15:23:45 +02:00
FocusSource.h LibGUI: Make focus events more aware of why focus is changing 2020-08-15 00:05:45 +02:00
Forward.h LibGUI: Move table view headers into their own widget 2020-08-26 00:51:35 +02:00
Frame.cpp LibGUI: Clip GUI::Frame children to the frame_inner_rect() 2020-08-26 00:51:35 +02:00
Frame.h Meta+LibC through LibHTTP: Make clang-format-10 clean 2020-09-25 21:18:17 +02:00
GroupBox.cpp
GroupBox.h
HeaderView.cpp LibGUI: Make table view row height+padding font-size-relative 2020-10-25 10:12:03 +01:00
HeaderView.h LibGUI: Make table view row height+padding font-size-relative 2020-10-25 10:12:03 +01:00
Icon.cpp
Icon.h Meta+LibC through LibHTTP: Make clang-format-10 clean 2020-09-25 21:18:17 +02:00
IconView.cpp LibGUI: Set vertical distance between icons relative to scroll value 2020-11-11 15:14:09 +01:00
IconView.h LibGUI: Improve and simplify IconView item name wrapping 2020-10-27 16:10:30 +01:00
ImageWidget.cpp
ImageWidget.h
INILexer.cpp
INILexer.h
INISyntaxHighlighter.cpp
INISyntaxHighlighter.h Meta+LibC through LibHTTP: Make clang-format-10 clean 2020-09-25 21:18:17 +02:00
InputBox.cpp
InputBox.h
ItemListModel.h DisplaySettings+LibGUI: Move ItemListModel into LibGUI 2020-08-29 17:42:03 +02:00
JsonArrayModel.cpp LibGUI: Remove unnecessary type cast in JsonArrayModel. 2020-09-20 21:10:46 +02:00
JsonArrayModel.h LibGUI: Remove unnecessary type cast in JsonArrayModel. 2020-09-20 21:10:46 +02:00
JSSyntaxHighlighter.cpp LibJS: Unify syntax highlighting 2020-10-04 23:41:31 +02:00
JSSyntaxHighlighter.h Spreadsheet: Add a syntax highlighter to the cell editor 2020-08-24 19:15:07 +02:00
Label.cpp LibGUI: Make GUI::Label respect the foreground color role 2020-10-23 11:57:00 +02:00
Label.h Meta+LibC through LibHTTP: Make clang-format-10 clean 2020-09-25 21:18:17 +02:00
Layout.cpp AK: Make RefPtr, NonnullRefPtr, WeakPtr thread safe 2020-11-10 19:11:52 +01:00
Layout.h LibCore: Make Core::Object properties more dynamic 2020-09-15 21:46:26 +02:00
LazyWidget.cpp
LazyWidget.h
ListView.cpp LibGUI: Model-less views should not swallow key events 2020-10-28 21:26:27 +01:00
ListView.h HackStudio: Add basic Git integration 2020-09-15 21:43:29 +02:00
Margins.h Meta+LibC through LibHTTP: Make clang-format-10 clean 2020-09-25 21:18:17 +02:00
Menu.cpp AK: Make RefPtr, NonnullRefPtr, WeakPtr thread safe 2020-11-10 19:11:52 +01:00
Menu.h
MenuBar.cpp
MenuBar.h
MenuItem.cpp
MenuItem.h
MessageBox.cpp Meta+LibC through LibHTTP: Make clang-format-10 clean 2020-09-25 21:18:17 +02:00
MessageBox.h
Model.cpp LibGUI+WindowServer: Make DragOperation hold a MimeData instance 2020-11-08 21:46:13 +01:00
Model.h LibGUI+WindowServer: Make DragOperation hold a MimeData instance 2020-11-08 21:46:13 +01:00
ModelEditingDelegate.h LibGUI: Allow rollback of model editing delegate input 2020-08-28 20:50:12 +02:00
ModelIndex.cpp LibGUI: Add formatter for ModelIndex. 2020-10-06 15:04:37 +02:00
ModelIndex.h LibGUI: Add formatter for ModelIndex. 2020-10-06 15:04:37 +02:00
ModelRole.h LibGUI+WindowServer: Make DragOperation hold a MimeData instance 2020-11-08 21:46:13 +01:00
ModelSelection.cpp
ModelSelection.h Meta+LibC through LibHTTP: Make clang-format-10 clean 2020-09-25 21:18:17 +02:00
MultiView.cpp LibGUI: Enable using a ColumnsView inside MultiView :^) 2020-08-16 16:44:09 +02:00
MultiView.h LibGUI: Enable using a ColumnsView inside MultiView :^) 2020-08-16 16:44:09 +02:00
Notification.cpp Meta+LibC through LibHTTP: Make clang-format-10 clean 2020-09-25 21:18:17 +02:00
Notification.h
Painter.cpp
Painter.h
ProcessChooser.cpp LibGUI: Set ProcessChooser key column and sort order after set_model (#3521) 2020-09-17 16:17:14 +02:00
ProcessChooser.h Meta+LibC through LibHTTP: Make clang-format-10 clean 2020-09-25 21:18:17 +02:00
ProgressBar.cpp
ProgressBar.h
RadioButton.cpp LibGUI+LibGfx: Improve focus rect appearance 2020-10-26 21:01:45 +01:00
RadioButton.h
ResizeCorner.cpp Meta+LibC through LibHTTP: Make clang-format-10 clean 2020-09-25 21:18:17 +02:00
ResizeCorner.h LibGUI: Use widget override cursors in GUI::ResizeCorner 2020-09-11 14:47:38 +02:00
RunningProcessesModel.cpp LibGUI: Move GUI::Model::Role to GUI::ModelRole 2020-08-16 16:44:09 +02:00
RunningProcessesModel.h LibGUI: Move GUI::Model::Role to GUI::ModelRole 2020-08-16 16:44:09 +02:00
ScrollableWidget.cpp LibGUI: Limit ScrollableWidget::available_size() width/height to 0 2020-11-08 17:21:11 +01:00
ScrollableWidget.h Meta+LibC through LibHTTP: Make clang-format-10 clean 2020-09-25 21:18:17 +02:00
ScrollBar.cpp Meta+LibC through LibHTTP: Make clang-format-10 clean 2020-09-25 21:18:17 +02:00
ScrollBar.h LibGUI: Make ScrollBar track the currently pressed component 2020-08-25 20:20:45 +02:00
ShellSyntaxHighlighter.cpp LibGUI: Update ShellSyntaxHighlighter to also highlight brace expansions 2020-10-25 10:09:27 +01:00
ShellSyntaxHighlighter.h LibGUI: Add a Shell syntax highlighter 2020-09-30 20:05:24 +02:00
Shortcut.cpp LibGUI: Use StringBuilder::join() in Shortcut::to_string() 2020-08-19 21:17:02 +02:00
Shortcut.h Meta+LibC through LibHTTP: Make clang-format-10 clean 2020-09-25 21:18:17 +02:00
Slider.cpp LibGUI: Increase slider acceleration with Ctrl (#3499) 2020-09-19 16:45:51 +02:00
Slider.h Meta+LibC through LibHTTP: Make clang-format-10 clean 2020-09-25 21:18:17 +02:00
SortingProxyModel.cpp LibGUI: Implement searching/jumping as you type in views 2020-10-22 15:23:45 +02:00
SortingProxyModel.h LibGUI: Implement searching/jumping as you type in views 2020-10-22 15:23:45 +02:00
SpinBox.cpp LibGUI: Add Widget focus policies 2020-10-30 17:03:28 +01:00
SpinBox.h LibGUI: Use on_up_pressed/on_down_pressed events in SpinBox 2020-09-23 20:44:23 +02:00
Splitter.cpp AK: Make RefPtr, NonnullRefPtr, WeakPtr thread safe 2020-11-10 19:11:52 +01:00
Splitter.h LibGUI: Splitter should only override cursor if within grabbable area 2020-08-27 10:42:15 +02:00
StackWidget.cpp LibGUI: Add Widget::has_focus_within() 2020-10-30 23:40:23 +01:00
StackWidget.h
StatusBar.cpp LibGUI: Hide ResizeCorner in StatusBar when window is maximized 2020-08-31 09:08:26 +02:00
StatusBar.h LibGUI: Hide ResizeCorner in StatusBar when window is maximized 2020-08-31 09:08:26 +02:00
SyntaxHighlighter.cpp AK: Make RefPtr, NonnullRefPtr, WeakPtr thread safe 2020-11-10 19:11:52 +01:00
SyntaxHighlighter.h LibGUI: Add a Shell syntax highlighter 2020-09-30 20:05:24 +02:00
TableView.cpp LibGUI: Remove redundant scroll_into_view() calls in TableView 2020-10-30 23:52:59 +01:00
TableView.h LibGUI: Paint a focus rect around the cursor index in TableView 2020-10-27 16:18:55 +01:00
TabWidget.cpp LibGUI: Add Widget::has_focus_within() 2020-10-30 23:40:23 +01:00
TabWidget.h LibGUI: Make TabWidget unfocusable when tab-less 2020-10-30 17:03:29 +01:00
TextBox.cpp Meta+LibC through LibHTTP: Make clang-format-10 clean 2020-09-25 21:18:17 +02:00
TextBox.h
TextDocument.cpp LibGUI: Add TextDocument::span_at(TextPosition) 2020-10-29 23:52:07 +01:00
TextDocument.h LibGUI: Add TextDocument::span_at(TextPosition) 2020-10-29 23:52:07 +01:00
TextEditor.cpp TextEditor: Change cursor behaviour when clicking empty space 2020-11-19 21:59:13 +01:00
TextEditor.h TextEditor: Go-to-line now shows line in middle of view (#4008) 2020-11-10 09:53:50 +01:00
TextPosition.h LibGUI: Add formatters for TextPosition and TextRange. 2020-10-06 20:29:26 +02:00
TextRange.h LibGUI: Add formatters for TextPosition and TextRange. 2020-10-06 20:29:26 +02:00
ToolBar.cpp LibGUI: Use ToolBarButton helper class inside ToolBar 2020-10-30 17:03:29 +01:00
ToolBar.h
ToolBarContainer.cpp LibGUI: Don't paint borders for invisible bars in ToolBarContainer 2020-10-03 19:43:25 +02:00
ToolBarContainer.h LibGUI: Don't accomodate invisible children in ToolBarContainer height 2020-10-03 14:01:37 +02:00
TreeView.cpp LibGUI: Model-less views should not swallow key events 2020-10-28 21:26:27 +01:00
TreeView.h LibGUI: Shrink the default selection rect of TreeView items 2020-10-27 20:33:30 +01:00
UndoStack.cpp
UndoStack.h
Variant.cpp
Variant.h Meta+LibC through LibHTTP: Make clang-format-10 clean 2020-09-25 21:18:17 +02:00
Widget.cpp AK: Make RefPtr, NonnullRefPtr, WeakPtr thread safe 2020-11-10 19:11:52 +01:00
Widget.h LibGUI: Add Widget::has_focus_within() 2020-10-30 23:40:23 +01:00
Window.cpp AK: Make RefPtr, NonnullRefPtr, WeakPtr thread safe 2020-11-10 19:11:52 +01:00
Window.h LibGUI: Improve automatic focus guessing somewhat 2020-10-30 17:03:29 +01:00
WindowServerConnection.cpp LibGUI: Ignore application-global shortcuts in modal windows 2020-11-10 19:41:03 +01:00
WindowServerConnection.h
WindowType.h