mirror of
https://github.com/LadybirdBrowser/ladybird.git
synced 2025-01-23 01:32:14 -05:00
895ab8e745
This finally makes tooltips on menu applets the same as everywhere else! Here's what went wrong: WindowManager::process_mouse_event() receives a Window*&, determines the hovered window and sets it accordingly. However there's a branch that tests for menubar_rect().contains(event.position()) and returns early - which resulted in hovered_window never being set to any MenuApplet window, even hovered ones. The hovered_window result is being used in WindowManager::event() and passed to WindowManager::set_hovered_window(), which is responsible for creating WindowLeft and WindowEntered events when the hovered window changes, as a result of the mentioned chain of events this also never happens for MenuApplet windows. The WindowLeft event would the cause Window::handle_left_event() in LibGUI to be called, which unsets the window's hovered widget, which is necessary for the widget to receive a subsequent Enter event - again, all of this never happened. Now it's working as expected though, so we can start using tooltips on menu applets :^) |
||
|---|---|---|
| .. | ||
| AudioServer | ||
| Clipboard | ||
| DHCPClient | ||
| ImageDecoder | ||
| LaunchServer | ||
| LookupServer | ||
| NotificationServer | ||
| ProtocolServer | ||
| SystemMenu | ||
| SystemServer | ||
| Taskbar | ||
| TelnetServer | ||
| WebContent | ||
| WebServer | ||
| WindowServer | ||
| CMakeLists.txt | ||