mirror of
https://github.com/LadybirdBrowser/ladybird.git
synced 2025-01-26 03:02:27 -05:00
65232b6681
These cases were found with GCC's `-Wsuggest-final-{types,methods}`
warnings, which catch calls that could have been devirtualized had we
declared the functions `final` in the source.
To reproduce, Link Time Optimization needs to be enabled. The easiest
way to achieve this is to set the `CMAKE_INTERPROCEDURAL_OPTIMIZATION`
cache variable to `ON`. The `.incbin` directive in LibCompress' Brotli
decompressor might needs to be changed to an absolute path for this to
work.
This commit also removes a pair of unused virtual functions.
53 lines
2 KiB
C++
53 lines
2 KiB
C++
/*
|
|
* Copyright (c) 2020-2021, Andreas Kling <kling@serenityos.org>
|
|
*
|
|
* SPDX-License-Identifier: BSD-2-Clause
|
|
*/
|
|
|
|
#pragma once
|
|
|
|
#include <LibJS/Runtime/Environment.h>
|
|
|
|
namespace JS {
|
|
|
|
class ObjectEnvironment final : public Environment {
|
|
JS_ENVIRONMENT(ObjectEnvironment, Environment);
|
|
|
|
public:
|
|
enum class IsWithEnvironment {
|
|
No,
|
|
Yes,
|
|
};
|
|
|
|
virtual ThrowCompletionOr<bool> has_binding(DeprecatedFlyString const& name, Optional<size_t>* = nullptr) const override;
|
|
virtual ThrowCompletionOr<void> create_mutable_binding(VM&, DeprecatedFlyString const& name, bool can_be_deleted) override;
|
|
virtual ThrowCompletionOr<void> create_immutable_binding(VM&, DeprecatedFlyString const& name, bool strict) override;
|
|
virtual ThrowCompletionOr<void> initialize_binding(VM&, DeprecatedFlyString const& name, Value, Environment::InitializeBindingHint) override;
|
|
virtual ThrowCompletionOr<void> set_mutable_binding(VM&, DeprecatedFlyString const& name, Value, bool strict) override;
|
|
virtual ThrowCompletionOr<Value> get_binding_value(VM&, DeprecatedFlyString const& name, bool strict) override;
|
|
virtual ThrowCompletionOr<bool> delete_binding(VM&, DeprecatedFlyString const& name) override;
|
|
|
|
// 9.1.1.2.10 WithBaseObject ( ), https://tc39.es/ecma262/#sec-object-environment-records-withbaseobject
|
|
virtual Object* with_base_object() const override
|
|
{
|
|
if (is_with_environment())
|
|
return m_binding_object;
|
|
return nullptr;
|
|
}
|
|
|
|
// [[BindingObject]], The binding object of this Environment Record.
|
|
Object& binding_object() { return m_binding_object; }
|
|
|
|
// [[IsWithEnvironment]], Indicates whether this Environment Record is created for a with statement.
|
|
bool is_with_environment() const { return m_with_environment; }
|
|
|
|
private:
|
|
ObjectEnvironment(Object& binding_object, IsWithEnvironment, Environment* outer_environment);
|
|
|
|
virtual void visit_edges(Visitor&) override;
|
|
|
|
NonnullGCPtr<Object> m_binding_object;
|
|
bool m_with_environment { false };
|
|
};
|
|
|
|
}
|