mirrors/linux
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2025-01-24 01:09:38 -05:00
Code Activity

powerpc/kexec_file: add missing of_node_put

Browse source 
for_each_node_with_property performs an of_node_get on each
iteration, so a break out of the loop requires an
of_node_put.

This was done using the Coccinelle semantic patch
iterators/for_each_child.cocci

Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://msgid.link/20230907095521.14053-7-Julia.Lawall@inria.fr
This commit is contained in:
Julia Lawall 2023-09-07 11:55:16 +02:00 • committed by Michael Ellerman
parent a59e9eb252
commit 06b627c123
1 changed files with 6 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
arch/powerpc/kexec/file_load_64.c
View file

@ -1138,11 +1138,15 @@ static int update_pci_dma_nodes(void *fdt, const char *dmapropname)
continue; continue;
ret = copy_property(fdt, pci_offset, dn, "ibm,dma-window"); ret = copy_property(fdt, pci_offset, dn, "ibm,dma-window");
if (ret < 0) if (ret < 0) {
of_node_put(dn);
break; break;
}
ret = copy_property(fdt, pci_offset, dn, dmapropname); ret = copy_property(fdt, pci_offset, dn, dmapropname);
if (ret < 0) if (ret < 0) {
of_node_put(dn);
break; break;
}
} }
return ret; return ret;