mirrors/linux
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2025-01-23 08:35:19 -05:00
Code Activity

i2c: ismt: kill transaction in hardware on timeout

Browse source 
On Intel Denverton SoC ismt controller may enter weird state when
transaction gets stuck. It times out in the driver, but unless
transaction is explicitly killed in the controller, it won't be able to
perform new transactions anymore.

The issue is extremely difficult to reproduce and may take weeks of non-
stop smbus traffic.

Numerous hours with logic analyzer didn't yield any useful results, it
looks like the controller stops toggling SCK line, i.e. the issue is
likely in the controller, since device doesn't do clock stretching, so
nothing is driving SCK except the host.

Explicitly kill transaction on timeout to recover the controller from
this state.

Signed-off-by: Vasily Khoruzhick <vasilykh@arista.com>
Signed-off-by: Andi Shyti <andi.shyti@kernel.org>
This commit is contained in:
Vasily Khoruzhick 2024-08-19 13:51:04 -07:00 • committed by Andi Shyti
parent 66049b33c0
commit 46b2dfc0aa
1 changed files with 10 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
drivers/i2c/busses/i2c-ismt.c
View file

@ -381,6 +381,15 @@ static int ismt_process_desc(const struct ismt_desc *desc,
return -EIO;
}
/**
* ismt_kill_transaction() - kill current transaction
* @priv: iSMT private data
*/
static void ismt_kill_transaction(struct ismt_priv *priv)
{
writel(ISMT_GCTRL_KILL, priv->smba + ISMT_GR_GCTRL);
}
/**
* ismt_access() - process an SMBus command
* @adap: the i2c host adapter
@ -623,6 +632,7 @@ static int ismt_access(struct i2c_adapter *adap, u16 addr,
dma_unmap_single(dev, dma_addr, dma_size, dma_direction);
if (unlikely(!time_left)) {
ismt_kill_transaction(priv);
ret = -ETIMEDOUT;
goto out;
}