mirrors/linux
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2025-01-22 07:53:11 -05:00
Code Activity

lockref: use bool for false/true returns

Browse source 
Replace int used as bool with the actual bool type for return values that
can only be true or false.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Link: https://lore.kernel.org/r/20250115094702.504610-4-hch@lst.de
Signed-off-by: Christian Brauner <brauner@kernel.org>
This commit is contained in:
Christoph Hellwig 2025-01-15 10:46:39 +01:00 committed by Christian Brauner
parent d60f2280a1
commit 6d2868d5b6
No known key found for this signature in database
GPG key ID: 91C61BC06578DCA2
2 changed files with 17 additions and 19 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
include/linux/lockref.h
View file

@ -36,11 +36,11 @@ struct lockref {
extern void lockref_get(struct lockref *);
extern int lockref_put_return(struct lockref *);
extern int lockref_get_not_zero(struct lockref *);
extern int lockref_put_or_lock(struct lockref *);
bool lockref_get_not_zero(struct lockref *lockref);
bool lockref_put_or_lock(struct lockref *lockref);
extern void lockref_mark_dead(struct lockref *);
extern int lockref_get_not_dead(struct lockref *);
bool lockref_get_not_dead(struct lockref *lockref);
/* Must be called under spinlock for reliable results */
static inline bool __lockref_is_dead(const struct lockref *l)

30
lib/lockref.c
View file

@ -58,23 +58,22 @@ EXPORT_SYMBOL(lockref_get);
* @lockref: pointer to lockref structure
* Return: 1 if count updated successfully or 0 if count was zero
*/
int lockref_get_not_zero(struct lockref *lockref)
bool lockref_get_not_zero(struct lockref *lockref)
{
int retval;
bool retval = false;
CMPXCHG_LOOP(
new.count++;
if (old.count <= 0)
return 0;
return false;
,
return 1;
return true;
);
spin_lock(&lockref->lock);
retval = 0;
if (lockref->count > 0) {
lockref->count++;
retval = 1;
retval = true;
}
spin_unlock(&lockref->lock);
return retval;
@ -106,22 +105,22 @@ EXPORT_SYMBOL(lockref_put_return);
* @lockref: pointer to lockref structure
* Return: 1 if count updated successfully or 0 if count <= 1 and lock taken
*/
int lockref_put_or_lock(struct lockref *lockref)
bool lockref_put_or_lock(struct lockref *lockref)
{
CMPXCHG_LOOP(
new.count--;
if (old.count <= 1)
break;
,
return 1;
return true;
);
spin_lock(&lockref->lock);
if (lockref->count <= 1)
return 0;
return false;
lockref->count--;
spin_unlock(&lockref->lock);
return 1;
return true;
}
EXPORT_SYMBOL(lockref_put_or_lock);
@ -141,23 +140,22 @@ EXPORT_SYMBOL(lockref_mark_dead);
* @lockref: pointer to lockref structure
* Return: 1 if count updated successfully or 0 if lockref was dead
*/
int lockref_get_not_dead(struct lockref *lockref)
bool lockref_get_not_dead(struct lockref *lockref)
{
int retval;
bool retval = false;
CMPXCHG_LOOP(
new.count++;
if (old.count < 0)
return 0;
return false;
,
return 1;
return true;
);
spin_lock(&lockref->lock);
retval = 0;
if (lockref->count >= 0) {
lockref->count++;
retval = 1;
retval = true;
}
spin_unlock(&lockref->lock);
return retval;