mirrors/linux
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2025-01-23 16:53:58 -05:00
Code Activity

clk: mxl: syscon_node_to_regmap() returns error pointers

Browse source 
Commit 036177310b ("clk: mxl: Switch from direct readl/writel based IO
to regmap based IO") introduced code resulting in below warning issued
by the smatch static checker.

  drivers/clk/x86/clk-lgm.c:441 lgm_cgu_probe() warn: passing zero to 'PTR_ERR'

Fix the warning by replacing incorrect IS_ERR_OR_NULL() with IS_ERR().

Fixes: 036177310b ("clk: mxl: Switch from direct readl/writel based IO to regmap based IO")
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Rahul Tanwar <rtanwar@maxlinear.com>
Link: https://lore.kernel.org/r/49e339d4739e4ae4c92b00c1b2918af0755d4122.1666695221.git.rtanwar@maxlinear.com
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
This commit is contained in:
Rahul Tanwar 2022-10-25 19:03:57 +08:00 • committed by Stephen Boyd
parent 106ef3bda2
commit 7256d1f461
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
drivers/clk/x86/clk-lgm.c
View file

@ -436,7 +436,7 @@ static int lgm_cgu_probe(struct platform_device *pdev)
ctx->clk_data.num = CLK_NR_CLKS; ctx->clk_data.num = CLK_NR_CLKS;
ctx->membase = syscon_node_to_regmap(np); ctx->membase = syscon_node_to_regmap(np);
if (IS_ERR_OR_NULL(ctx->membase)) { if (IS_ERR(ctx->membase)) {
dev_err(dev, "Failed to get clk CGU iomem\n"); dev_err(dev, "Failed to get clk CGU iomem\n");
return PTR_ERR(ctx->membase); return PTR_ERR(ctx->membase);
} }