mirrors/linux
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2025-01-23 16:53:58 -05:00
Code Activity

rcu-tasks: Fix synchronize_rcu_tasks_trace() header comment

Browse source 
The synchronize_rcu_tasks_trace() header comment incorrectly claims that
any number of things delimit RCU Tasks Trace read-side critical sections,
when in fact only rcu_read_lock_trace() and rcu_read_unlock_trace() do so.
This commit therefore fixes this comment, and, while in the area, fixes
a typo in the rcu_read_lock_trace() header comment.

Reported-by: Alexei Starovoitov <alexei.starovoitov@gmail.com>
Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
This commit is contained in:
Paul E. McKenney 2020-06-12 13:11:29 -07:00
parent e13ef442fe
commit c7dcf8106f
2 changed files with 6 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
include/linux/rcupdate_trace.h
View file

@ -36,8 +36,8 @@ void rcu_read_unlock_trace_special(struct task_struct *t, int nesting);
/** /**
* rcu_read_lock_trace - mark beginning of RCU-trace read-side critical section * rcu_read_lock_trace - mark beginning of RCU-trace read-side critical section
* *
* When synchronize_rcu_trace() is invoked by one task, then that task * When synchronize_rcu_tasks_trace() is invoked by one task, then that
* is guaranteed to block until all other tasks exit their read-side * task is guaranteed to block until all other tasks exit their read-side
* critical sections. Similarly, if call_rcu_trace() is invoked on one * critical sections. Similarly, if call_rcu_trace() is invoked on one
* task while other tasks are within RCU read-side critical sections, * task while other tasks are within RCU read-side critical sections,
* invocation of the corresponding RCU callback is deferred until after * invocation of the corresponding RCU callback is deferred until after

9
kernel/rcu/tasks.h
View file

@ -1118,11 +1118,10 @@ EXPORT_SYMBOL_GPL(call_rcu_tasks_trace);
* synchronize_rcu_tasks_trace - wait for a trace rcu-tasks grace period * synchronize_rcu_tasks_trace - wait for a trace rcu-tasks grace period
* *
* Control will return to the caller some time after a trace rcu-tasks * Control will return to the caller some time after a trace rcu-tasks
* grace period has elapsed, in other words after all currently * grace period has elapsed, in other words after all currently executing
* executing rcu-tasks read-side critical sections have elapsed. These * rcu-tasks read-side critical sections have elapsed. These read-side
* read-side critical sections are delimited by calls to schedule(), * critical sections are delimited by calls to rcu_read_lock_trace()
* cond_resched_tasks_rcu_qs(), userspace execution, and (in theory, * and rcu_read_unlock_trace().
* anyway) cond_resched().
* *
* This is a very specialized primitive, intended only for a few uses in * This is a very specialized primitive, intended only for a few uses in
* tracing and other situations requiring manipulation of function preambles * tracing and other situations requiring manipulation of function preambles