mirrors/linux
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2025-01-23 08:35:19 -05:00
Code Activity

ALSA: usb: Use DIV_ROUND_UP() instead of open-coding it

Browse source 
Use DIV_ROUND_UP() instead of open-coding it. This documents intent
and makes it more clear what is going on for the casual reviewer.

Generated using the following the Coccinelle semantic patch.

// <smpl>
@@
expression x, y;
@@
-(((x) + (y) - 1) / (y))
+DIV_ROUND_UP(x, y)
// </smpl>

Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Link: https://lore.kernel.org/r/20201223172229.781-11-lars@metafoo.de
Signed-off-by: Takashi Iwai <tiwai@suse.de>
This commit is contained in:
Lars-Peter Clausen 2020-12-23 18:22:22 +01:00 committed by Takashi Iwai
parent a434713bfe
commit e4d8aef214
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
sound/usb/mixer.c
View file

@ -254,7 +254,7 @@ static int get_relative_value(struct usb_mixer_elem_info *cval, int val)
if (val < cval->min) if (val < cval->min)
return 0; return 0;
else if (val >= cval->max) else if (val >= cval->max)
return (cval->max - cval->min + cval->res - 1) / cval->res; return DIV_ROUND_UP(cval->max - cval->min, cval->res);
else else
return (val - cval->min) / cval->res; return (val - cval->min) / cval->res;
} }
@ -1338,7 +1338,7 @@ static int mixer_ctl_feature_info(struct snd_kcontrol *kcontrol,
} }
uinfo->value.integer.min = 0; uinfo->value.integer.min = 0;
uinfo->value.integer.max = uinfo->value.integer.max =
(cval->max - cval->min + cval->res - 1) / cval->res; DIV_ROUND_UP(cval->max - cval->min, cval->res);
} }
return 0; return 0;
} }