mirrors/linux
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2025-01-26 18:43:33 -05:00
Code Activity

net: Push protocol type directly down to header_ops->cache()

Browse source 
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
David S. Miller 2011-07-12 23:28:12 -07:00
parent 3769cffb1c
commit e69dd336ee
7 changed files with 13 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
drivers/firewire/net.c
View file

@ -261,16 +261,16 @@ static int fwnet_header_rebuild(struct sk_buff *skb)
} }
static int fwnet_header_cache(const struct neighbour *neigh, static int fwnet_header_cache(const struct neighbour *neigh,
struct hh_cache *hh) struct hh_cache *hh, __be16 type)
{ {
struct net_device *net; struct net_device *net;
struct fwnet_header *h; struct fwnet_header *h;
if (hh->hh_type == cpu_to_be16(ETH_P_802_3)) if (type == cpu_to_be16(ETH_P_802_3))
return -1; return -1;
net = neigh->dev; net = neigh->dev;
h = (struct fwnet_header *)((u8 *)hh->hh_data + 16 - sizeof(*h)); h = (struct fwnet_header *)((u8 *)hh->hh_data + 16 - sizeof(*h));
h->h_proto = hh->hh_type; h->h_proto = type;
memcpy(h->h_dest, neigh->ha, net->addr_len); memcpy(h->h_dest, neigh->ha, net->addr_len);
hh->hh_len = FWNET_HLEN; hh->hh_len = FWNET_HLEN;

5
drivers/isdn/i4l/isdn_net.c
View file

@ -1983,13 +1983,14 @@ isdn_net_rebuild_header(struct sk_buff *skb)
return ret; return ret;
} }
static int isdn_header_cache(const struct neighbour *neigh, struct hh_cache *hh) static int isdn_header_cache(const struct neighbour *neigh, struct hh_cache *hh,
__be16 type)
{ {
const struct net_device *dev = neigh->dev; const struct net_device *dev = neigh->dev;
isdn_net_local *lp = netdev_priv(dev); isdn_net_local *lp = netdev_priv(dev);
if (lp->p_encap == ISDN_NET_ENCAP_ETHER) if (lp->p_encap == ISDN_NET_ENCAP_ETHER)
return eth_header_cache(neigh, hh); return eth_header_cache(neigh, hh, type);
return -1; return -1;
} }

6
drivers/net/plip.c
View file

@ -152,7 +152,7 @@ static int plip_hard_header(struct sk_buff *skb, struct net_device *dev,
unsigned short type, const void *daddr, unsigned short type, const void *daddr,
const void *saddr, unsigned len); const void *saddr, unsigned len);
static int plip_hard_header_cache(const struct neighbour *neigh, static int plip_hard_header_cache(const struct neighbour *neigh,
struct hh_cache *hh); struct hh_cache *hh, __be16 type);
static int plip_open(struct net_device *dev); static int plip_open(struct net_device *dev);
static int plip_close(struct net_device *dev); static int plip_close(struct net_device *dev);
static int plip_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd); static int plip_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd);
@ -1026,11 +1026,11 @@ plip_hard_header(struct sk_buff *skb, struct net_device *dev,
} }
static int plip_hard_header_cache(const struct neighbour *neigh, static int plip_hard_header_cache(const struct neighbour *neigh,
struct hh_cache *hh) struct hh_cache *hh, __be16 type)
{ {
int ret; int ret;
ret = eth_header_cache(neigh, hh); ret = eth_header_cache(neigh, hh, type);
if (ret == 0) { if (ret == 0) {
struct ethhdr *eth; struct ethhdr *eth;

2
include/linux/etherdevice.h
View file

@ -38,7 +38,7 @@ extern int eth_header(struct sk_buff *skb, struct net_device *dev,
const void *daddr, const void *saddr, unsigned len); const void *daddr, const void *saddr, unsigned len);
extern int eth_rebuild_header(struct sk_buff *skb); extern int eth_rebuild_header(struct sk_buff *skb);
extern int eth_header_parse(const struct sk_buff *skb, unsigned char *haddr); extern int eth_header_parse(const struct sk_buff *skb, unsigned char *haddr);
extern int eth_header_cache(const struct neighbour *neigh, struct hh_cache *hh); extern int eth_header_cache(const struct neighbour *neigh, struct hh_cache *hh, __be16 type);
extern void eth_header_cache_update(struct hh_cache *hh, extern void eth_header_cache_update(struct hh_cache *hh,
const struct net_device *dev, const struct net_device *dev,
const unsigned char *haddr); const unsigned char *haddr);

2
include/linux/netdevice.h
View file

@ -308,7 +308,7 @@ struct header_ops {
const void *saddr, unsigned len); const void *saddr, unsigned len);
int (*parse)(const struct sk_buff *skb, unsigned char *haddr); int (*parse)(const struct sk_buff *skb, unsigned char *haddr);
int (*rebuild)(struct sk_buff *skb); int (*rebuild)(struct sk_buff *skb);
int (*cache)(const struct neighbour *neigh, struct hh_cache *hh); int (*cache)(const struct neighbour *neigh, struct hh_cache *hh, __be16 type);
void (*cache_update)(struct hh_cache *hh, void (*cache_update)(struct hh_cache *hh,
const struct net_device *dev, const struct net_device *dev,
const unsigned char *haddr); const unsigned char *haddr);

2
net/core/neighbour.c
View file

@ -1247,7 +1247,7 @@ static void neigh_hh_init(struct neighbour *n, struct dst_entry *dst,
hh->hh_type = protocol; hh->hh_type = protocol;
atomic_set(&hh->hh_refcnt, 2); atomic_set(&hh->hh_refcnt, 2);
if (dev->header_ops->cache(n, hh)) { if (dev->header_ops->cache(n, hh, protocol)) {
kfree(hh); kfree(hh);
return; return;
} }

3
net/ethernet/eth.c
View file

@ -233,9 +233,8 @@ EXPORT_SYMBOL(eth_header_parse);
* @hh: destination cache entry * @hh: destination cache entry
* Create an Ethernet header template from the neighbour. * Create an Ethernet header template from the neighbour.
*/ */
int eth_header_cache(const struct neighbour *neigh, struct hh_cache *hh) int eth_header_cache(const struct neighbour *neigh, struct hh_cache *hh, __be16 type)
{ {
__be16 type = hh->hh_type;
struct ethhdr *eth; struct ethhdr *eth;
const struct net_device *dev = neigh->dev; const struct net_device *dev = neigh->dev;