1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2025-01-22 07:53:11 -05:00
linux/drivers/firmware/arm_scmi
Arnd Bergmann 514b2262ad firmware: arm_scmi: Fix i.MX build dependency
The newly added SCMI vendor driver references functions in the
protocol driver but needs a Kconfig dependency to ensure it can link,
essentially the Kconfig dependency needs to be reversed to match the
link time dependency:

  |  arm-linux-gnueabi-ld: sound/soc/fsl/fsl_mqs.o: in function `fsl_mqs_sm_write':
  |  	fsl_mqs.c:(.text+0x1aa): undefined reference to `scmi_imx_misc_ctrl_set'
  |  arm-linux-gnueabi-ld: sound/soc/fsl/fsl_mqs.o: in function `fsl_mqs_sm_read':
  |  	fsl_mqs.c:(.text+0x1ee): undefined reference to `scmi_imx_misc_ctrl_get'

This however only works after changing the dependency in the SND_SOC_FSL_MQS
driver as well, which uses 'select IMX_SCMI_MISC_DRV' to turn on a
driver it depends on. This is generally a bad idea, so the best solution
is to change that into a dependency.

To allow the ASoC driver to keep building with the SCMI support, this
needs to be an optional dependency that enforces the link-time
dependency if IMX_SCMI_MISC_DRV is a loadable module but not
depend on it if that is disabled.

Fixes: 61c9f03e22 ("firmware: arm_scmi: Add initial support for i.MX MISC protocol")
Fixes: 101c902359 ("ASoC: fsl_mqs: Support accessing registers by scmi interface")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Mark Brown <broonie@kernel.org>
Acked-by: Shengjiu Wang <shengjiu.wang@gmail.com>
Message-Id: <20241115230555.2435004-1-arnd@kernel.org>
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
2024-12-03 15:47:11 +00:00
..
transports firmware: arm_scmi: Calculate virtio PDU max size dynamically 2024-10-28 14:51:10 +00:00
vendors/imx firmware: arm_scmi: Fix i.MX build dependency 2024-12-03 15:47:11 +00:00
base.c
bus.c firmware: arm_scmi: Fix slab-use-after-free in scmi_bus_notifier() 2024-10-22 09:53:51 +01:00
clock.c
common.h Arm SCMI updates for v6.13 2024-11-12 15:56:51 +01:00
driver.c Char/Misc/IIO/Whatever driver subsystem updates for 6.13-rc1 2024-11-29 11:58:27 -08:00
Kconfig
Makefile
msg.c
notify.c
notify.h
perf.c firmware: arm_scmi: Report duplicate opps as firmware bugs 2024-11-12 19:45:25 +01:00
pinctrl.c
power.c
powercap.c
protocols.h
raw_mode.c
raw_mode.h
reset.c
scmi_power_control.c
sensors.c
shmem.c firmware: arm_scmi: Account for SHMEM memory overhead 2024-10-28 14:51:10 +00:00
system.c
voltage.c