Samuel Mendoza-Jonas 0795fb2021 net/ncsi: Stop monitor if channel times out or is inactive ... ncsi_channel_monitor() misses stopping the channel monitor in several places that it should, causing a WARN_ON_ONCE() to trigger when the monitor is re-started later, eg: [ 459.040000] WARNING: CPU: 0 PID: 1093 at net/ncsi/ncsi-manage.c:269 ncsi_start_channel_monitor+0x7c/0x90 [ 459.040000] CPU: 0 PID: 1093 Comm: kworker/0:3 Not tainted 4.10.17-gaca2fdd #140 [ 459.040000] Hardware name: ASpeed SoC [ 459.040000] Workqueue: events ncsi_dev_work [ 459.040000] [<80010094>] (unwind_backtrace) from [<8000d950>] (show_stack+0x20/0x24) [ 459.040000] [<8000d950>] (show_stack) from [<801dbf70>] (dump_stack+0x20/0x28) [ 459.040000] [<801dbf70>] (dump_stack) from [<80018d7c>] (__warn+0xe0/0x108) [ 459.040000] [<80018d7c>] (__warn) from [<80018e70>] (warn_slowpath_null+0x30/0x38) [ 459.040000] [<80018e70>] (warn_slowpath_null) from [<803f6a08>] (ncsi_start_channel_monitor+0x7c/0x90) [ 459.040000] [<803f6a08>] (ncsi_start_channel_monitor) from [<803f7664>] (ncsi_configure_channel+0xdc/0x5fc) [ 459.040000] [<803f7664>] (ncsi_configure_channel) from [<803f8160>] (ncsi_dev_work+0xac/0x474) [ 459.040000] [<803f8160>] (ncsi_dev_work) from [<8002d244>] (process_one_work+0x1e0/0x450) [ 459.040000] [<8002d244>] (process_one_work) from [<8002d510>] (worker_thread+0x5c/0x570) [ 459.040000] [<8002d510>] (worker_thread) from [<80033614>] (kthread+0x124/0x164) [ 459.040000] [<80033614>] (kthread) from [<8000a5e8>] (ret_from_fork+0x14/0x2c) This also updates the monitor instead of just returning if ncsi_xmit_cmd() fails to send the get-link-status command so that the monitor properly times out. Fixes: e6f44ed6d0 "net/ncsi: Package and channel management" Signed-off-by: Samuel Mendoza-Jonas <sam@mendozajonas.com> Signed-off-by: David S. Miller <davem@davemloft.net>		2017-10-21 01:56:38 +01:00
..
6lowpan
9p
802
8021q	net: 8021q: skip packets if the vlan is down	2017-10-04 18:16:48 -07:00
appletalk
atm
ax25
batman-adv
bluetooth	Revert "Bluetooth: Add option for disabling legacy ioctl interfaces"	2017-09-28 13:20:32 -07:00
bpf
bridge	netfilter: ebtables: fix race condition in frame_filter_net_init()	2017-09-29 13:36:06 +02:00
caif
can
ceph	libceph: don't allow bidirectional swap of pg-upmap-items	2017-09-19 20:34:29 +02:00
core	bpf: remove mark access for SK_SKB program types	2017-10-20 13:01:29 +01:00
dcb
dccp	tcp/dccp: fix ireq->opt races	2017-10-21 01:33:19 +01:00
decnet
dns_resolver
dsa	net: dsa: Fix network device registration order	2017-09-28 10:12:53 -07:00
ethernet
hsr
ieee802154
ife
ipv4	tcp/dccp: fix ireq->opt races	2017-10-21 01:33:19 +01:00
ipv6	Merge git://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf	2017-10-09 10:39:52 -07:00
ipx
iucv
kcm
key
l2tp	l2tp: check ps->sock before running pppol2tp_session_ioctl()	2017-10-14 18:38:56 -07:00
l3mdev
lapb
llc
mac80211	mac80211: accept key reinstall without changing anything	2017-10-16 13:02:03 +02:00
mac802154
mpls
ncsi	net/ncsi: Stop monitor if channel times out or is inactive	2017-10-21 01:56:38 +01:00
netfilter	netfilter: xt_bpf: Fix XT_BPF_MODE_FD_PINNED mode of 'xt_bpf_info_v1'	2017-10-09 15:18:04 +02:00
netlabel
netlink	netlink: fix netlink_ack() extack race	2017-10-18 12:22:28 +01:00
netrom
nfc
nsh
openvswitch	openvswitch: Fix an error handling path in 'ovs_nla_init_match_and_action()'	2017-09-12 20:37:31 -07:00
packet	packet: avoid panic in packet_getsockopt()	2017-10-21 01:51:34 +01:00
phonet
psample
qrtr
rds	rds: Fix incorrect statistics counting	2017-09-07 20:07:13 -07:00
rfkill
rose
rxrpc
sched	net/sched: cls_flower: Set egress_dev mark when calling into the HW driver	2017-10-16 21:18:59 +01:00
sctp	sctp: add the missing sock_owned_by_user check in sctp_icmp_redirect	2017-10-20 12:53:45 +01:00
smc	net/smc: no close wait in case of process shut down	2017-09-21 15:31:03 -07:00
strparser
sunrpc	sunrpc: remove redundant initialization of sock	2017-10-01 18:51:30 -04:00
switchdev
tipc	tipc: Unclone message at secondary destination lookup	2017-10-08 21:13:23 -07:00
tls	tls: make tls_sw_free_resources static	2017-09-14 09:55:21 -07:00
unix
vmw_vsock
wimax
wireless	nl80211: Define policy for packet pattern attributes	2017-10-04 14:39:21 +02:00
x25
xfrm	xfrm: don't call xfrm_policy_cache_flush under xfrm_state_lock	2017-09-28 09:39:05 +02:00
compat.c	net: compat: assert the size of cmsg copied in is as expected	2017-09-20 15:36:18 -07:00
Kconfig
Makefile
socket.c
sysctl_net.c