Steven Rostedt (Google) 292a089d78 treewide: Convert del_timer*() to timer_shutdown*() ... Due to several bugs caused by timers being re-armed after they are shutdown and just before they are freed, a new state of timers was added called "shutdown". After a timer is set to this state, then it can no longer be re-armed. The following script was run to find all the trivial locations where del_timer() or del_timer_sync() is called in the same function that the object holding the timer is freed. It also ignores any locations where the timer->function is modified between the del_timer*() and the free(), as that is not considered a "trivial" case. This was created by using a coccinelle script and the following commands: $ cat timer.cocci @@ expression ptr, slab; identifier timer, rfield; @@ ( - del_timer(&ptr->timer); + timer_shutdown(&ptr->timer); | - del_timer_sync(&ptr->timer); + timer_shutdown_sync(&ptr->timer); ) ... when strict when != ptr->timer ( kfree_rcu(ptr, rfield); | kmem_cache_free(slab, ptr); | kfree(ptr); ) $ spatch timer.cocci . > /tmp/t.patch $ patch -p1 < /tmp/t.patch Link: https://lore.kernel.org/lkml/20221123201306.823305113@linutronix.de/ Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org> Acked-by: Pavel Machek <pavel@ucw.cz> [ LED ] Acked-by: Kalle Valo <kvalo@kernel.org> [ wireless ] Acked-by: Paolo Abeni <pabeni@redhat.com> [ networking ] Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>		2022-12-25 13:38:09 -08:00
..
ipset	treewide: Convert del_timer*() to timer_shutdown*()	2022-12-25 13:38:09 -08:00
ipvs	treewide: Convert del_timer*() to timer_shutdown*()	2022-12-25 13:38:09 -08:00
core.c	Remove DECnet support from kernel	2022-08-22 14:26:30 +01:00
Kconfig	net: move the nat function to nf_nat_ovs for ovs and tc	2022-12-12 10:14:03 +00:00
Makefile	net: move the nat function to nf_nat_ovs for ovs and tc	2022-12-12 10:14:03 +00:00
nf_conncount.c
nf_conntrack_acct.c
nf_conntrack_amanda.c
nf_conntrack_bpf.c	bpf: Refactor btf_struct_access	2022-11-14 21:52:45 -08:00
nf_conntrack_broadcast.c
nf_conntrack_core.c	Networking changes for 6.2.	2022-12-13 15:47:48 -08:00
nf_conntrack_ecache.c
nf_conntrack_expect.c
nf_conntrack_extend.c
nf_conntrack_ftp.c	netfilter: nf_ct_ftp: fix deadlock when nat rewrite is needed	2022-09-20 23:50:03 +02:00
nf_conntrack_h323_asn1.c
nf_conntrack_h323_main.c
nf_conntrack_h323_types.c
nf_conntrack_helper.c	net: move add ct helper function to nf_conntrack_helper for ovs and tc	2022-11-08 12:15:19 +01:00
nf_conntrack_irc.c	netfilter: nf_conntrack_irc: Tighten matching on DCC message	2022-09-07 15:55:23 +02:00
nf_conntrack_labels.c
nf_conntrack_netbios_ns.c
nf_conntrack_netlink.c	netfilter: ctnetlink: fix compilation warning after data race fixes in ct mark	2022-11-30 13:08:49 +01:00
nf_conntrack_pptp.c
nf_conntrack_proto.c	netfilter: conntrack: merge ipv4+ipv6 confirm functions	2022-11-30 18:55:30 +01:00
nf_conntrack_proto_dccp.c
nf_conntrack_proto_generic.c
nf_conntrack_proto_gre.c
nf_conntrack_proto_icmp.c
nf_conntrack_proto_icmpv6.c	netfilter: conntrack: set icmpv6 redirects as RELATED	2022-11-30 23:01:20 +01:00
nf_conntrack_proto_sctp.c	netfilter: conntrack: add sctp DATA_SENT state	2022-11-30 18:26:09 +01:00
nf_conntrack_proto_tcp.c	netfilter: conntrack: reduce timeout when receiving out-of-window fin or rst	2022-09-07 16:46:03 +02:00
nf_conntrack_proto_udp.c
nf_conntrack_sane.c
nf_conntrack_seqadj.c
nf_conntrack_sip.c	netfilter: nf_conntrack_sip: fix ct_sip_walk_headers	2022-09-07 15:06:26 +02:00
nf_conntrack_snmp.c
nf_conntrack_standalone.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netfilter/nf-next	2022-12-12 14:45:36 -08:00
nf_conntrack_tftp.c
nf_conntrack_timeout.c
nf_conntrack_timestamp.c
nf_dup_netdev.c
nf_flow_table_core.c	netfilter: flowtable: fix stuck flows on cleanup due to pending work	2022-08-24 07:43:21 +02:00
nf_flow_table_inet.c
nf_flow_table_ip.c	netfilter: flowtable: add a 'default' case to flowtable datapath	2022-12-08 22:11:00 +01:00
nf_flow_table_offload.c	netfilter: flowtable: really fix NAT IPv6 offload	2022-12-08 21:43:25 +01:00
nf_flow_table_procfs.c
nf_hooks_lwtunnel.c
nf_internals.h
nf_log.c	netfilter: move from strlcpy with unused retval to strscpy	2022-09-07 16:46:03 +02:00
nf_log_syslog.c
nf_nat_amanda.c	netfilter: nat: move repetitive nat port reserve loop to a helper	2022-09-07 16:46:04 +02:00
nf_nat_bpf.c	net: netfilter: move bpf_ct_set_nat_info kfunc in nf_nat_bpf.c	2022-10-03 09:17:32 -07:00
nf_nat_core.c	netfilter: nf_nat: Fix possible memory leak in nf_nat_init()	2022-11-02 10:47:22 +01:00
nf_nat_ftp.c	netfilter: nat: move repetitive nat port reserve loop to a helper	2022-09-07 16:46:04 +02:00
nf_nat_helper.c	treewide: use get_random_u32_below() instead of deprecated function	2022-11-18 02:15:15 +01:00
nf_nat_irc.c	netfilter: nat: move repetitive nat port reserve loop to a helper	2022-09-07 16:46:04 +02:00
nf_nat_masquerade.c
nf_nat_ovs.c	net: move the nat function to nf_nat_ovs for ovs and tc	2022-12-12 10:14:03 +00:00
nf_nat_proto.c
nf_nat_redirect.c
nf_nat_sip.c	netfilter: nat: move repetitive nat port reserve loop to a helper	2022-09-07 16:46:04 +02:00
nf_nat_tftp.c
nf_queue.c
nf_sockopt.c
nf_synproxy_core.c
nf_tables_api.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netfilter/nf-next	2022-12-12 14:45:36 -08:00
nf_tables_core.c	netfilter: nft_inner: support for inner tunnel header matching	2022-10-25 13:48:42 +02:00
nf_tables_offload.c
nf_tables_trace.c
nfnetlink.c	netfilter: nfnetlink: fix potential dead lock in nfnetlink_rcv_msg()	2022-11-08 23:16:13 +01:00
nfnetlink_acct.c
nfnetlink_cthelper.c
nfnetlink_cttimeout.c
nfnetlink_hook.c	Remove DECnet support from kernel	2022-08-22 14:26:30 +01:00
nfnetlink_log.c
nfnetlink_osf.c	netfilter: nfnetlink_osf: fix possible bogus match in nf_osf_find()	2022-09-07 15:55:28 +02:00
nfnetlink_queue.c
nft_bitwise.c	netfilter: nf_tables: Extend nft_expr_ops::dump callback parameters	2022-11-15 10:46:34 +01:00
nft_byteorder.c	netfilter: nf_tables: Extend nft_expr_ops::dump callback parameters	2022-11-15 10:46:34 +01:00
nft_chain_filter.c
nft_chain_nat.c
nft_chain_route.c
nft_cmp.c	netfilter: nf_tables: Extend nft_expr_ops::dump callback parameters	2022-11-15 10:46:34 +01:00
nft_compat.c	netfilter: nf_tables: Extend nft_expr_ops::dump callback parameters	2022-11-15 10:46:34 +01:00
nft_connlimit.c	netfilter: nf_tables: Extend nft_expr_ops::dump callback parameters	2022-11-15 10:46:34 +01:00
nft_counter.c	netfilter: nf_tables: Introduce NFT_MSG_GETRULE_RESET	2022-11-15 10:53:17 +01:00
nft_ct.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2022-11-29 13:04:52 -08:00
nft_dup_netdev.c	netfilter: nf_tables: Extend nft_expr_ops::dump callback parameters	2022-11-15 10:46:34 +01:00
nft_dynset.c	netfilter: nf_tables: Introduce NFT_MSG_GETRULE_RESET	2022-11-15 10:53:17 +01:00
nft_exthdr.c	sctp: move SCTP_PAD4 and SCTP_TRUNC4 to linux/sctp.h	2022-11-17 21:43:34 -08:00
nft_fib.c	netfilter: nf_tables: Extend nft_expr_ops::dump callback parameters	2022-11-15 10:46:34 +01:00
nft_fib_inet.c
nft_fib_netdev.c
nft_flow_offload.c	netfilter: nf_tables: Extend nft_expr_ops::dump callback parameters	2022-11-15 10:46:34 +01:00
nft_fwd_netdev.c	netfilter: nf_tables: Extend nft_expr_ops::dump callback parameters	2022-11-15 10:46:34 +01:00
nft_hash.c	netfilter: nf_tables: Extend nft_expr_ops::dump callback parameters	2022-11-15 10:46:34 +01:00
nft_immediate.c	netfilter: nf_tables: Extend nft_expr_ops::dump callback parameters	2022-11-15 10:46:34 +01:00
nft_inner.c	netfilter: nf_tables: Introduce NFT_MSG_GETRULE_RESET	2022-11-15 10:53:17 +01:00
nft_last.c	netfilter: nf_tables: Extend nft_expr_ops::dump callback parameters	2022-11-15 10:46:34 +01:00
nft_limit.c	netfilter: nf_tables: Extend nft_expr_ops::dump callback parameters	2022-11-15 10:46:34 +01:00
nft_log.c	netfilter: nf_tables: Extend nft_expr_ops::dump callback parameters	2022-11-15 10:46:34 +01:00
nft_lookup.c	netfilter: nf_tables: Extend nft_expr_ops::dump callback parameters	2022-11-15 10:46:34 +01:00
nft_masq.c	netfilter: nf_tables: Extend nft_expr_ops::dump callback parameters	2022-11-15 10:46:34 +01:00
nft_meta.c	netfilter: nf_tables: Extend nft_expr_ops::dump callback parameters	2022-11-15 10:46:34 +01:00
nft_nat.c	netfilter: nf_tables: Extend nft_expr_ops::dump callback parameters	2022-11-15 10:46:34 +01:00
nft_numgen.c	netfilter: nf_tables: Extend nft_expr_ops::dump callback parameters	2022-11-15 10:46:34 +01:00
nft_objref.c	netfilter: nf_tables: Extend nft_expr_ops::dump callback parameters	2022-11-15 10:46:34 +01:00
nft_osf.c	netfilter: nf_tables: Extend nft_expr_ops::dump callback parameters	2022-11-15 10:46:34 +01:00
nft_payload.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netfilter/nf-next	2022-11-15 20:33:20 -08:00
nft_queue.c	netfilter: nf_tables: Extend nft_expr_ops::dump callback parameters	2022-11-15 10:46:34 +01:00
nft_quota.c	netfilter: nf_tables: Introduce NFT_MSG_GETRULE_RESET	2022-11-15 10:53:17 +01:00
nft_range.c	netfilter: nf_tables: Extend nft_expr_ops::dump callback parameters	2022-11-15 10:46:34 +01:00
nft_redir.c	netfilter: nf_tables: Extend nft_expr_ops::dump callback parameters	2022-11-15 10:46:34 +01:00
nft_reject.c	netfilter: nf_tables: Extend nft_expr_ops::dump callback parameters	2022-11-15 10:46:34 +01:00
nft_reject_inet.c
nft_reject_netdev.c
nft_rt.c	netfilter: nf_tables: Extend nft_expr_ops::dump callback parameters	2022-11-15 10:46:34 +01:00
nft_set_bitmap.c
nft_set_hash.c
nft_set_pipapo.c	netfilter: nft_set_pipapo: Actually validate intervals in fields after the first one	2022-11-28 13:17:11 +01:00
nft_set_pipapo.h
nft_set_pipapo_avx2.c
nft_set_pipapo_avx2.h
nft_set_rbtree.c
nft_socket.c	netfilter: nf_tables: Extend nft_expr_ops::dump callback parameters	2022-11-15 10:46:34 +01:00
nft_synproxy.c	netfilter: nf_tables: Extend nft_expr_ops::dump callback parameters	2022-11-15 10:46:34 +01:00
nft_tproxy.c	netfilter: nf_tables: Extend nft_expr_ops::dump callback parameters	2022-11-15 10:46:34 +01:00
nft_tunnel.c	netfilter: nf_tables: Extend nft_expr_ops::dump callback parameters	2022-11-15 10:46:34 +01:00
nft_xfrm.c	netfilter: nf_tables: Extend nft_expr_ops::dump callback parameters	2022-11-15 10:46:34 +01:00
utils.c
x_tables.c	netfilter: move from strlcpy with unused retval to strscpy	2022-09-07 16:46:03 +02:00
xt_addrtype.c
xt_AUDIT.c
xt_bpf.c
xt_cgroup.c
xt_CHECKSUM.c
xt_CLASSIFY.c
xt_cluster.c
xt_comment.c
xt_connbytes.c
xt_connlabel.c
xt_connlimit.c
xt_connmark.c	netfilter: conntrack: Fix data-races around ct mark	2022-11-18 15:21:00 +01:00
xt_CONNSECMARK.c
xt_conntrack.c
xt_cpu.c
xt_CT.c
xt_dccp.c
xt_devgroup.c
xt_dscp.c
xt_DSCP.c
xt_ecn.c
xt_esp.c
xt_hashlimit.c
xt_helper.c
xt_hl.c
xt_HL.c
xt_HMARK.c
xt_IDLETIMER.c	treewide: Convert del_timer*() to timer_shutdown*()	2022-12-25 13:38:09 -08:00
xt_ipcomp.c
xt_iprange.c
xt_ipvs.c
xt_l2tp.c
xt_LED.c	treewide: Convert del_timer*() to timer_shutdown*()	2022-12-25 13:38:09 -08:00
xt_length.c
xt_limit.c
xt_LOG.c
xt_mac.c
xt_mark.c
xt_MASQUERADE.c
xt_multiport.c
xt_nat.c
xt_NETMAP.c
xt_nfacct.c
xt_NFLOG.c
xt_NFQUEUE.c
xt_osf.c
xt_owner.c
xt_physdev.c
xt_pkttype.c
xt_policy.c
xt_quota.c
xt_RATEEST.c	netfilter: move from strlcpy with unused retval to strscpy	2022-09-07 16:46:03 +02:00
xt_rateest.c
xt_realm.c
xt_recent.c
xt_REDIRECT.c
xt_repldata.h
xt_sctp.c	sctp: move SCTP_PAD4 and SCTP_TRUNC4 to linux/sctp.h	2022-11-17 21:43:34 -08:00
xt_SECMARK.c
xt_set.c
xt_socket.c
xt_state.c
xt_statistic.c	treewide: use get_random_u32() when possible	2022-10-11 17:42:58 -06:00
xt_string.c
xt_TCPMSS.c
xt_tcpmss.c
xt_TCPOPTSTRIP.c
xt_tcpudp.c
xt_TEE.c
xt_time.c
xt_TPROXY.c
xt_TRACE.c
xt_u32.c