1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2025-01-26 18:43:33 -05:00
linux/include/net
Denys Vlasenko 9b2c45d479 net: make getname() functions return length rather than use int* parameter
Changes since v1:
Added changes in these files:
    drivers/infiniband/hw/usnic/usnic_transport.c
    drivers/staging/lustre/lnet/lnet/lib-socket.c
    drivers/target/iscsi/iscsi_target_login.c
    drivers/vhost/net.c
    fs/dlm/lowcomms.c
    fs/ocfs2/cluster/tcp.c
    security/tomoyo/network.c

Before:
All these functions either return a negative error indicator,
or store length of sockaddr into "int *socklen" parameter
and return zero on success.

"int *socklen" parameter is awkward. For example, if caller does not
care, it still needs to provide on-stack storage for the value
it does not need.

None of the many FOO_getname() functions of various protocols
ever used old value of *socklen. They always just overwrite it.

This change drops this parameter, and makes all these functions, on success,
return length of sockaddr. It's always >= 0 and can be differentiated
from an error.

Tests in callers are changed from "if (err)" to "if (err < 0)", where needed.

rpc_sockname() lost "int buflen" parameter, since its only use was
to be passed to kernel_getsockname() as &buflen and subsequently
not used in any way.

Userspace API is not changed.

    text    data     bss      dec     hex filename
30108430 2633624  873672 33615726 200ef6e vmlinux.before.o
30108109 2633612  873672 33615393 200ee21 vmlinux.o

Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
CC: David S. Miller <davem@davemloft.net>
CC: linux-kernel@vger.kernel.org
CC: netdev@vger.kernel.org
CC: linux-bluetooth@vger.kernel.org
CC: linux-decnet-user@lists.sourceforge.net
CC: linux-wireless@vger.kernel.org
CC: linux-rdma@vger.kernel.org
CC: linux-sctp@vger.kernel.org
CC: linux-nfs@vger.kernel.org
CC: linux-x25@vger.kernel.org
Signed-off-by: David S. Miller <davem@davemloft.net>
2018-02-12 14:15:04 -05:00
..
9p
bluetooth net: annotate ->poll() instances 2017-11-27 16:20:04 -05:00
caif caif: reduce stack size with KASAN 2018-01-19 14:02:12 -05:00
iucv net: annotate ->poll() instances 2017-11-27 16:20:04 -05:00
netfilter netfilter: nf_flow_offload: fix use-after-free and a resource leak 2018-02-07 11:55:52 +01:00
netns Merge git://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf-next 2018-01-21 11:35:34 -05:00
nfc
phonet
sctp Currently, hardened usercopy performs dynamic bounds checking on slab 2018-02-03 16:25:42 -08:00
tc_act net/sched: act_csum: don't use spinlock in the fast path 2018-01-23 19:51:46 -05:00
6lowpan.h
act_api.h net_sched: switch to exit_batch for action pernet ops 2017-12-13 13:58:41 -05:00
addrconf.h rtnetlink: ipv6: convert remaining users to rtnl_register_module 2017-12-04 13:35:36 -05:00
af_ieee802154.h
af_rxrpc.h
af_unix.h
af_vsock.h
ah.h
arp.h ipv4: Make neigh lookup keys for loopback/point-to-point devices be INADDR_ANY 2018-01-15 14:53:43 -05:00
atmclip.h
ax25.h
ax88796.h
bond_3ad.h
bond_alb.h
bond_options.h
bonding.h
busy_poll.h
calipso.h
cfg80211-wext.h
cfg80211.h Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net 2018-01-17 00:10:42 -05:00
cfg802154.h
checksum.h
cipso_ipv4.h
cls_cgroup.h
codel.h
codel_impl.h
codel_qdisc.h
compat.h
datalink.h
dcbevent.h
dcbnl.h
devlink.h devlink: Add relation between dpipe and resource 2018-01-16 14:15:34 -05:00
dn.h
dn_dev.h
dn_fib.h
dn_neigh.h
dn_nsp.h
dn_route.h decnet: Move dn_next into decnet route structure. 2017-11-30 09:54:25 -05:00
dsa.h net: dsa: Allow compiling out legacy support 2017-12-07 14:14:54 -05:00
dsfield.h
dst.h Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net 2018-01-29 10:15:51 -05:00
dst_cache.h
dst_metadata.h
dst_ops.h
erspan.h net: erspan: fix metadata extraction 2018-02-06 11:32:48 -05:00
esp.h
ethoc.h
fib_notifier.h
fib_rules.h
firewire.h
flow.h
flow_dissector.h
fou.h
fq.h
fq_impl.h
garp.h
gen_stats.h net: sched: add support for TCQ_F_NOLOCK subqueues to sch_mq 2017-12-08 13:32:26 -05:00
genetlink.h
geneve.h
gre.h
gro_cells.h
gtp.h
gue.h fou: fix some member types in guehdr 2017-12-11 14:10:06 -05:00
hwbm.h
icmp.h
ieee80211_radiotap.h
ieee802154_netdev.h
if_inet6.h
ife.h
ila.h
inet6_connection_sock.h
inet6_hashtables.h
inet_common.h net: make getname() functions return length rather than use int* parameter 2018-02-12 14:15:04 -05:00
inet_connection_sock.h vfs: do bulk POLL* -> EPOLL* replacement 2018-02-11 14:34:03 -08:00
inet_ecn.h
inet_frag.h
inet_hashtables.h inet: Add a 2nd listener hashtable (port+addr) 2017-12-03 10:18:28 -05:00
inet_sock.h net: sock: replace sk_state_load with inet_sk_state_load and remove sk_state_store 2017-12-20 14:00:25 -05:00
inet_timewait_sock.h tcp/dccp: avoid one atomic operation for timewait hashdance 2017-12-13 14:33:10 -05:00
inetpeer.h
ip.h Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net 2017-12-16 22:11:55 -05:00
ip6_checksum.h
ip6_fib.h ipv6: Add support for non-equal-cost multipath 2018-01-10 15:14:44 -05:00
ip6_route.h ipv6: Calculate hash thresholds for IPv6 nexthops 2018-01-10 15:14:44 -05:00
ip6_tunnel.h ip6_gre: add erspan v2 support 2017-12-15 12:34:00 -05:00
ip_fib.h
ip_tunnels.h net: erspan: introduce erspan v2 for ip_gre 2017-12-15 12:34:00 -05:00
ip_vs.h netfilter: ipvs: Remove useless ipvsh param of frag_safe_skb_hp 2018-01-08 18:01:02 +01:00
ipcomp.h
ipconfig.h
ipv6.h net: make getname() functions return length rather than use int* parameter 2018-02-12 14:15:04 -05:00
ipx.h
iw_handler.h
kcm.h
l3mdev.h
lapb.h
lib80211.h
llc.h
llc_c_ac.h
llc_c_ev.h
llc_c_st.h
llc_conn.h
llc_if.h
llc_pdu.h
llc_s_ac.h
llc_s_ev.h
llc_s_st.h
llc_sap.h
lwtunnel.h
mac80211.h Revert "mac80211: Add TXQ scheduling API" 2017-12-19 10:12:48 +01:00
mac802154.h
mip6.h
mld.h
mpls.h
mpls_iptunnel.h
mrp.h
ncsi.h
ndisc.h
neighbour.h
net_namespace.h Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net 2018-01-29 10:15:51 -05:00
net_ratelimit.h
netevent.h
netlabel.h
netlink.h
netprio_cgroup.h
netrom.h
nexthop.h
nl802154.h
nsh.h
p8022.h
ping.h
pkt_cls.h pkt_cls: add new tc cls helper to check offload flag and chain index 2018-01-25 21:23:07 -05:00
pkt_sched.h net: remove prototype of qdisc_lookup_class() 2018-01-16 14:56:54 -05:00
pptp.h
protocol.h
psample.h
psnap.h
raw.h
rawv6.h
red.h net_sched: red: Avoid illegal values 2017-12-05 14:37:13 -05:00
regulatory.h
request_sock.h
rose.h
route.h ip_rt_ioctl(): take copyin to caller 2018-01-24 19:13:45 -05:00
rtnetlink.h rtnetlink: remove __rtnl_register 2017-12-04 11:32:53 -05:00
sch_generic.h net_sched: plug in qdisc ops change_tx_queue_len 2018-01-29 12:42:15 -05:00
scm.h
secure_seq.h
seg6.h
seg6_hmac.h
slhc_vj.h
smc.h
snmp.h
sock.h net: make getname() functions return length rather than use int* parameter 2018-02-12 14:15:04 -05:00
sock_reuseport.h
Space.h
stp.h
strparser.h
switchdev.h
tcp.h bpf: sockmap, add sock close() hook to remove socks 2018-02-06 11:39:32 +01:00
tcp_states.h
timewait_sock.h
tipc.h
tls.h tls: Add support for encryption using async offload accelerator 2018-01-31 10:26:30 -05:00
transp_v6.h
tso.h
tun_proto.h
udp.h net: annotate ->poll() instances 2017-11-27 16:20:04 -05:00
udp_tunnel.h
udplite.h
vsock_addr.h
vxlan.h vxlan: Fix trailing semicolon 2018-01-17 16:07:24 -05:00
wext.h lift handling of SIOCIW... out of dev_ioctl() 2018-01-24 19:13:45 -05:00
wimax.h
x25.h
x25device.h
xdp.h xdp/qede: setup xdp_rxq_info and intro xdp_rxq_info_is_reg 2018-01-05 15:21:21 -08:00
xfrm.h xfrm: Add ESN support for IPSec HW offload 2018-01-18 10:42:59 +01:00