Chengfeng Ye 08e50cf071 tipc: fix a potential deadlock on &tx->lock ... It seems that tipc_crypto_key_revoke() could be be invoked by wokequeue tipc_crypto_work_rx() under process context and timer/rx callback under softirq context, thus the lock acquisition on &tx->lock seems better use spin_lock_bh() to prevent possible deadlock. This flaw was found by an experimental static analysis tool I am developing for irq-related deadlock. tipc_crypto_work_rx() <workqueue> --> tipc_crypto_key_distr() --> tipc_bcast_xmit() --> tipc_bcbase_xmit() --> tipc_bearer_bc_xmit() --> tipc_crypto_xmit() --> tipc_ehdr_build() --> tipc_crypto_key_revoke() --> spin_lock(&tx->lock) <timer interrupt> --> tipc_disc_timeout() --> tipc_bearer_xmit_skb() --> tipc_crypto_xmit() --> tipc_ehdr_build() --> tipc_crypto_key_revoke() --> spin_lock(&tx->lock) <deadlock here> Signed-off-by: Chengfeng Ye <dg573847474@gmail.com> Reviewed-by: Jacob Keller <jacob.e.keller@intel.com> Acked-by: Jon Maloy <jmaloy@redhat.com> Fixes: fc1b6d6de2 ("tipc: introduce TIPC encryption & authentication") Link: https://lore.kernel.org/r/20230927181414.59928-1-dg573847474@gmail.com Signed-off-by: Jakub Kicinski <kuba@kernel.org>		2023-10-04 13:24:12 -07:00
..
addr.c
addr.h	tipc: Remove unused function declarations	2023-08-03 12:51:45 +02:00
bcast.c
bcast.h
bearer.c
bearer.h	tipc: Remove unused function declarations	2023-08-03 12:51:45 +02:00
core.c
core.h	minmax: add in_range() macro	2023-08-24 16:20:18 -07:00
crypto.c	tipc: fix a potential deadlock on &tx->lock	2023-10-04 13:24:12 -07:00
crypto.h
diag.c
discover.c
discover.h
eth_media.c
group.c
group.h
ib_media.c
Kconfig
link.c	minmax: add in_range() macro	2023-08-24 16:20:18 -07:00
link.h	tipc: Remove unused declaration tipc_link_build_bc_sync_msg()	2023-08-09 13:03:14 -07:00
Makefile
monitor.c
monitor.h
msg.c
msg.h
name_distr.c
name_distr.h	tipc: Remove unused function declarations	2023-08-03 12:51:45 +02:00
name_table.c
name_table.h
net.c
net.h	tipc: Remove unused function declarations	2023-08-03 12:51:45 +02:00
netlink.c
netlink.h
netlink_compat.c	genetlink: use attrs from struct genl_info	2023-08-15 15:00:45 -07:00
node.c	genetlink: use attrs from struct genl_info	2023-08-15 15:00:45 -07:00
node.h
socket.c	genetlink: use attrs from struct genl_info	2023-08-15 15:00:45 -07:00
socket.h
subscr.c
subscr.h
sysctl.c
topsrv.c
topsrv.h
trace.c
trace.h
udp_media.c	genetlink: use attrs from struct genl_info	2023-08-15 15:00:45 -07:00
udp_media.h