1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2025-01-26 18:43:33 -05:00
linux/sound/hda
Tuo Li 1f4a08fed4 ALSA: hda: fix a possible null-pointer dereference due to data race in snd_hdac_regmap_sync()
The variable codec->regmap is often protected by the lock
codec->regmap_lock when is accessed. However, it is accessed without
holding the lock when is accessed in snd_hdac_regmap_sync():

  if (codec->regmap)

In my opinion, this may be a harmful race, because if codec->regmap is
set to NULL right after the condition is checked, a null-pointer
dereference can occur in the called function regcache_sync():

  map->lock(map->lock_arg); --> Line 360 in drivers/base/regmap/regcache.c

To fix this possible null-pointer dereference caused by data race, the
mutex_lock coverage is extended to protect the if statement as well as the
function call to regcache_sync().

[ Note: the lack of the regmap_lock itself is harmless for the current
  codec driver implementations, as snd_hdac_regmap_sync() is only for
  PM runtime resume that is prohibited during the codec probe.
  But the change makes the whole code more consistent, so it's merged
  as is -- tiwai ]

Reported-by: BassCheck <bass@buaa.edu.cn>
Signed-off-by: Tuo Li <islituo@gmail.com>
Link: https://lore.kernel.org/r/20230703031016.1184711-1-islituo@gmail.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
2023-07-03 10:08:12 +02:00
..
ext
array.c
hda_bus_type.c
hdac_bus.c
hdac_component.c
hdac_controller.c ALSA: hda: Using polling mode for loongson controller by default 2023-06-07 12:37:25 +02:00
hdac_device.c Merge branch 'for-next' into for-linus 2023-06-26 15:23:23 +02:00
hdac_i915.c
hdac_regmap.c ALSA: hda: fix a possible null-pointer dereference due to data race in snd_hdac_regmap_sync() 2023-07-03 10:08:12 +02:00
hdac_stream.c ALSA: hda: Workaround for SDnCTL register on loongson 2023-06-07 12:41:21 +02:00
hdac_sysfs.c
hdmi_chmap.c
intel-dsp-config.c ALSA: hda: intel-dsp-config: add MTL PCI id 2023-03-08 06:37:19 +01:00
intel-nhlt.c
intel-sdw-acpi.c
Kconfig
local.h
Makefile
trace.c
trace.h