mirrors/serenity
1
0
Fork 0
mirror of https://github.com/SerenityOS/serenity.git synced 2025-01-23 09:51:57 -05:00
Code Issues Projects Releases Packages Wiki Activity
serenity/AK/Demangle.h

35 lines
666 B
C
Raw Normal View History

Meta: Add license header to source files As suggested by Joshua, this commit adds the 2-clause BSD license as a comment block to the top of every source file. For the first pass, I've just added myself for simplicity. I encourage everyone to add themselves as copyright holders of any file they've added or modified in some significant way. If I've added myself in error somewhere, feel free to replace it with the appropriate copyright holder instead. Going forward, all new source files should include a license header.
2020-01-18 09:38:21 +01:00
/*
* Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org>
*
Everything: Move to SPDX license identifiers in all files. SPDX License Identifiers are a more compact / standardized way of representing file license information. See: https://spdx.dev/resources/use/#identifiers This was done with the `ambr` search and replace tool. ambr --no-parent-ignore --key-from-file --rep-from-file key.txt rep.txt *
2021-04-22 01:24:48 -07:00
* SPDX-License-Identifier: BSD-2-Clause
Meta: Add license header to source files As suggested by Joshua, this commit adds the 2-clause BSD license as a comment block to the top of every source file. For the first pass, I've just added myself for simplicity. I encourage everyone to add themselves as copyright holders of any file they've added or modified in some significant way. If I've added myself in error somewhere, feel free to replace it with the appropriate copyright holder instead. Going forward, all new source files should include a license header.
2020-01-18 09:38:21 +01:00
*/
Kernel: Demangle kernel C++ symbols correctly again I broke this while implementing module linking. Also move the actual demangling work to AK, in AK::demangle(const char*)
2019-11-29 14:55:07 +01:00
#pragma once
#include <AK/String.h>
AK: Reduce header dependency graph of String.h String.h no longer pulls in StringView.h. We do this by moving a bunch of String functions out-of-line.
2020-03-23 13:45:10 +01:00
#include <AK/StringView.h>
AK: The <cxxabi.h> header is not available during Toolchain build This will need some refinement, but basically since we build LibC during the toolchain build, we don't have libstdc++ headers yet.
2020-02-03 06:26:32 +01:00
Revert "AK: Don't demangle in serenity :(" This reverts commit 4361a502255e409f04c9325ef73f3cd10f9cafdb.
2020-05-20 14:23:32 +02:00
#ifndef BUILDING_SERENITY_TOOLCHAIN
AK: Reduce header dependency graph of String.h String.h no longer pulls in StringView.h. We do this by moving a bunch of String functions out-of-line.
2020-03-23 13:45:10 +01:00
# include <cxxabi.h>
AK: The <cxxabi.h> header is not available during Toolchain build This will need some refinement, but basically since we build LibC during the toolchain build, we don't have libstdc++ headers yet.
2020-02-03 06:26:32 +01:00
#endif
Kernel: Demangle kernel C++ symbols correctly again I broke this while implementing module linking. Also move the actual demangling work to AK, in AK::demangle(const char*)
2019-11-29 14:55:07 +01:00
namespace AK {
Kernel+LibELF: Don't blindly trust ELF symbol offsets in symbolication It was possible to craft a custom ELF executable that when symbolicated would cause the kernel to read from user-controlled addresses anywhere in memory. You could then fetch this memory via /proc/PID/stack We fix this by making ELFImage hand out StringView rather than raw const char* for symbol names. In case a symbol offset is outside the ELF image, you get a null StringView. :^) Test: Kernel/elf-symbolication-kernel-read-exploit.cpp
2020-01-16 22:04:44 +01:00
inline String demangle(const StringView& name)
Kernel: Demangle kernel C++ symbols correctly again I broke this while implementing module linking. Also move the actual demangling work to AK, in AK::demangle(const char*)
2019-11-29 14:55:07 +01:00
{
Revert "AK: Don't demangle in serenity :(" This reverts commit 4361a502255e409f04c9325ef73f3cd10f9cafdb.
2020-05-20 14:23:32 +02:00
#ifdef BUILDING_SERENITY_TOOLCHAIN
AK: The <cxxabi.h> header is not available during Toolchain build This will need some refinement, but basically since we build LibC during the toolchain build, we don't have libstdc++ headers yet.
2020-02-03 06:26:32 +01:00
return name;
#else
Kernel: Demangle kernel C++ symbols correctly again I broke this while implementing module linking. Also move the actual demangling work to AK, in AK::demangle(const char*)
2019-11-29 14:55:07 +01:00
int status = 0;
Misc: Replace "String(string_view)" with "string_view.to_string()" StringView::to_string() was added in 917ccb1 but not actually used anywhere yet.
2020-05-06 18:18:24 +01:00
auto* demangled_name = abi::__cxa_demangle(name.to_string().characters(), nullptr, nullptr, &status);
Kernel: Demangle kernel C++ symbols correctly again I broke this while implementing module linking. Also move the actual demangling work to AK, in AK::demangle(const char*)
2019-11-29 14:55:07 +01:00
auto string = String(status == 0 ? demangled_name : name);
if (status == 0)
kfree(demangled_name);
return string;
AK: The <cxxabi.h> header is not available during Toolchain build This will need some refinement, but basically since we build LibC during the toolchain build, we don't have libstdc++ headers yet.
2020-02-03 06:26:32 +01:00
#endif
Kernel: Demangle kernel C++ symbols correctly again I broke this while implementing module linking. Also move the actual demangling work to AK, in AK::demangle(const char*)
2019-11-29 14:55:07 +01:00
}
}
using AK::demangle;
Reference in a new issue Copy permalink