mirrors/serenity
1
0
Fork 0
mirror of https://github.com/SerenityOS/serenity.git synced 2025-01-24 02:12:09 -05:00
Code Issues Projects Releases Packages Wiki Activity

LibWeb: Set both start and end in Selection::extend

Browse source 
(cherry picked from commit f41cbfa2a9c1ff21890581d0ae87334ff1e780e6)
This commit is contained in:
Gingeh 2024-10-13 15:28:25 +11:00 • committed by Nico Weber
parent 1c7ca6d33e
commit 1a1ccd3a92
1 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
Userland/Libraries/LibWeb/Selection/Selection.cpp
View file

@ -262,8 +262,8 @@ WebIDL::ExceptionOr<void> Selection::collapse_to_end()
// https://w3c.github.io/selection-api/#dom-selection-extend
WebIDL::ExceptionOr<void> Selection::extend(JS::NonnullGCPtr<DOM::Node> node, unsigned offset)
{
// 1. If node's root is not the document associated with this, abort these steps.
if (&node->root() != m_document.ptr())
// 1. If the document associated with this is not a shadow-including inclusive ancestor of node, abort these steps.
if (!m_document->is_shadow_including_inclusive_ancestor_of(node))
return {};
// 2. If this is empty, throw an InvalidStateError exception and abort these steps.
@ -284,9 +284,11 @@ WebIDL::ExceptionOr<void> Selection::extend(JS::NonnullGCPtr<DOM::Node> node, un
// 5. If node's root is not the same as the this's range's root, set the start newRange's start and end to newFocus.
if (&node->root() != &m_range->start_container()->root()) {
TRY(new_range->set_start(new_focus_node, new_focus_offset));
TRY(new_range->set_end(new_focus_node, new_focus_offset));
}
// 6. Otherwise, if oldAnchor is before or equal to newFocus, set the start newRange's start to oldAnchor, then set its end to newFocus.
else if (old_anchor_node.is_before(new_focus_node) || &old_anchor_node == new_focus_node.ptr()) {
TRY(new_range->set_start(old_anchor_node, old_anchor_offset));
TRY(new_range->set_end(new_focus_node, new_focus_offset));
}
// 7. Otherwise, set the start newRange's start to newFocus, then set its end to oldAnchor.