mirrors/serenity
1
0
Fork 0
mirror of https://github.com/SerenityOS/serenity.git synced 2025-01-22 09:21:57 -05:00
Code Issues Projects Releases Packages Wiki Activity

Meta: Don't use the gtk,gl=on display backend with NVIDIA graphics

Browse source 
This is quite a crude check and may lead to false positives. But it's
better than having a black screen on systems with NVIDIA graphics.
This commit is contained in:
Sönke Holz 2024-11-30 21:48:55 +01:00 committed by Nico Weber
parent 5175a014f0
commit 220e6d8f3d
1 changed files with 5 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
Meta/run.py
View file

@ -570,6 +570,10 @@ def set_up_screens(config: Configuration):
if provided_display_backend is not None:
config.display_backend = provided_display_backend
else:
# The `gtk,gl=on` display backend appears to be broken on systems with NVIDIA graphics.
# Check if `nvidia-smi` is installed; if it is, assume that NVIDIA drivers would be used.
is_linux_with_nvidia_graphics = sys.platform == "linux" and which("nvidia-smi") is not None
qemu_display_info = run(
[str(config.qemu_binary), "-display", "help"],
capture_output=True,
@ -584,7 +588,7 @@ def set_up_screens(config: Configuration):
config.display_backend = "sdl,gl=off"
elif config.screen_count > 1 and "sdl" in qemu_display_info:
config.display_backend = "sdl,gl=off"
elif "gtk" in qemu_display_info and has_virgl():
elif "gtk" in qemu_display_info and has_virgl() and not is_linux_with_nvidia_graphics:
config.display_backend = "gtk,gl=on"
elif "sdl" in qemu_display_info and has_virgl():
config.display_backend = "sdl,gl=on"