mirrors/serenity
1
0
Fork 0
mirror of https://github.com/SerenityOS/serenity.git synced 2025-01-24 02:12:09 -05:00
Code Issues Projects Releases Packages Wiki Activity

Kernel: Do less unnecessary work when tearing down process address space

Browse source 
When deleting an entire AddressSpace, we don't need to do TLB flushes
at all (since the entire page directory is going away anyway).

We also don't need to deallocate VM ranges one by one, since the entire
VM range allocator will be deleted anyway.
This commit is contained in:
Andreas Kling 2022-01-12 13:48:43 +01:00
parent a702b6ec42
commit 2323cdd914
3 changed files with 7 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
Kernel/Memory/AddressSpace.cpp
View file

@ -320,7 +320,10 @@ void AddressSpace::dump_regions()
void AddressSpace::remove_all_regions(Badge<Process>) void AddressSpace::remove_all_regions(Badge<Process>)
{ {
VERIFY(Thread::current() == g_finalizer);
SpinlockLocker lock(m_lock); SpinlockLocker lock(m_lock);
for (auto& region : m_regions)
(*region).unmap(Region::ShouldDeallocateVirtualRange::No, ShouldFlushTLB::No);
m_regions.clear(); m_regions.clear();
} }

5
Kernel/Memory/Region.cpp
View file

@ -234,7 +234,7 @@ bool Region::remap_vmobject_page(size_t page_index, bool with_flush)
return success; return success;
} }
void Region::unmap(ShouldDeallocateVirtualRange deallocate_range) void Region::unmap(ShouldDeallocateVirtualRange deallocate_range, ShouldFlushTLB should_flush_tlb)
{ {
if (!m_page_directory) if (!m_page_directory)
return; return;
@ -245,7 +245,8 @@ void Region::unmap(ShouldDeallocateVirtualRange deallocate_range)
auto vaddr = vaddr_from_page_index(i); auto vaddr = vaddr_from_page_index(i);
MM.release_pte(*m_page_directory, vaddr, i == count - 1 ? MemoryManager::IsLastPTERelease::Yes : MemoryManager::IsLastPTERelease::No); MM.release_pte(*m_page_directory, vaddr, i == count - 1 ? MemoryManager::IsLastPTERelease::Yes : MemoryManager::IsLastPTERelease::No);
} }
MemoryManager::flush_tlb(m_page_directory, vaddr(), page_count()); if (should_flush_tlb == ShouldFlushTLB::Yes)
MemoryManager::flush_tlb(m_page_directory, vaddr(), page_count());
if (deallocate_range == ShouldDeallocateVirtualRange::Yes) { if (deallocate_range == ShouldDeallocateVirtualRange::Yes) {
m_page_directory->range_allocator().deallocate(range()); m_page_directory->range_allocator().deallocate(range());
} }

2
Kernel/Memory/Region.h
View file

@ -178,7 +178,7 @@ public:
No, No,
Yes, Yes,
}; };
void unmap(ShouldDeallocateVirtualRange = ShouldDeallocateVirtualRange::Yes); void unmap(ShouldDeallocateVirtualRange, ShouldFlushTLB = ShouldFlushTLB::Yes);
void remap(); void remap();