mirrors/serenity
1
0
Fork 0
mirror of https://github.com/SerenityOS/serenity.git synced 2025-01-23 09:51:57 -05:00
Code Issues Projects Releases Packages Wiki Activity

LibJS: Add spec comments to greater_than()

Browse source
This commit is contained in:
Linus Groh 2022-12-10 00:04:07 +00:00
parent 058a247c61
commit 444ba191af
1 changed files with 12 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
Userland/Libraries/LibJS/Runtime/Value.cpp
View file

@ -1213,12 +1213,23 @@ ThrowCompletionOr<FunctionObject*> Value::get_method(VM& vm, PropertyKey const&
}
// 13.10 Relational Operators, https://tc39.es/ecma262/#sec-relational-operators
// RelationalExpression : RelationalExpression > ShiftExpression
ThrowCompletionOr<Value> greater_than(VM& vm, Value lhs, Value rhs)
{
// 1. Let lref be ? Evaluation of RelationalExpression.
// 2. Let lval be ? GetValue(lref).
// 3. Let rref be ? Evaluation of ShiftExpression.
// 4. Let rval be ? GetValue(rref).
// NOTE: This is handled in the AST or Bytecode interpreter.
// OPTIMIZATION: If both values are i32, we can do a direct comparison without calling into IsLessThan.
if (lhs.is_int32() && rhs.is_int32())
return lhs.as_i32() > rhs.as_i32();
TriState relation = TRY(is_less_than(vm, lhs, rhs, false));
// 5. Let r be ? IsLessThan(rval, lval, false).
auto relation = TRY(is_less_than(vm, lhs, rhs, false));
// 6. If r is undefined, return false. Otherwise, return r.
if (relation == TriState::Unknown)
return Value(false);
return Value(relation == TriState::True);