From 62a25aa46d9ddf2b976c74273d8ff35f725e8d84 Mon Sep 17 00:00:00 2001
From: RatcheT2497 <ratchetnumbers@proton.me>
Date: Wed, 15 Jan 2025 20:10:24 +0100
Subject: [PATCH] Kernel/RTL8168: Change wrong u32 mmio reads to u8

Crash caused by erroneous reading of a few 8bit registers as 32bit,
causing an unaligned access panic.
---
 Kernel/Net/Realtek/RTL8168NetworkAdapter.cpp | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/Kernel/Net/Realtek/RTL8168NetworkAdapter.cpp b/Kernel/Net/Realtek/RTL8168NetworkAdapter.cpp
index 74cfba4dc7b..0bded1875a1 100644
--- a/Kernel/Net/Realtek/RTL8168NetworkAdapter.cpp
+++ b/Kernel/Net/Realtek/RTL8168NetworkAdapter.cpp
@@ -299,7 +299,7 @@ UNMAP_AFTER_INIT ErrorOr<void> RTL8168NetworkAdapter::initialize(Badge<Networkin
         // disable CMAC
         out8(REG_IBCR2, in8(REG_IBCR2) & ~1);
 
-        while ((in32(REG_IBISR0) & 0x2) != 0)
+        while ((in8(REG_IBISR0) & 0x2) != 0)
             Processor::wait_check();
 
         out8(REG_IBISR0, in8(REG_IBISR0) | 0x20);
@@ -314,7 +314,7 @@ UNMAP_AFTER_INIT ErrorOr<void> RTL8168NetworkAdapter::initialize(Badge<Networkin
         while ((in32(REG_TXCFG) & TXCFG_EMPTY) == 0)
             Processor::wait_check();
 
-        while ((in32(REG_MCU) & (MCU_RX_EMPTY | MCU_TX_EMPTY)) == 0)
+        while ((in8(REG_MCU) & (MCU_RX_EMPTY | MCU_TX_EMPTY)) == 0)
             Processor::wait_check();
 
         out8(REG_COMMAND, in8(REG_COMMAND) & ~(COMMAND_RX_ENABLE | COMMAND_TX_ENABLE));
@@ -325,7 +325,7 @@ UNMAP_AFTER_INIT ErrorOr<void> RTL8168NetworkAdapter::initialize(Badge<Networkin
         data &= ~(1 << 14);
         ocp_out(0xe8de, data);
 
-        while ((in32(REG_MCU) & MCU_LINK_LIST_READY) == 0)
+        while ((in8(REG_MCU) & MCU_LINK_LIST_READY) == 0)
             Processor::wait_check();
 
         // vendor magic values ???
@@ -333,7 +333,7 @@ UNMAP_AFTER_INIT ErrorOr<void> RTL8168NetworkAdapter::initialize(Badge<Networkin
         data |= (1 << 15);
         ocp_out(0xe8de, data);
 
-        while ((in32(REG_MCU) & MCU_LINK_LIST_READY) == 0)
+        while ((in8(REG_MCU) & MCU_LINK_LIST_READY) == 0)
             Processor::wait_check();
     }